DE-7017: Generic improvements (#37)

* FEATURES Add option to configure visibility of player controls and to fully hide them. Make base theme configurable: audio controls, full screen button, track controls. Add support for UI cues. Add support for companion component above the bottom bar of player controls. * FIXES Fix rounding of video duration. Now all values with remainder 0.8 and higher are rounded UP instead of down, to produce a more accurate value. * REFACTOR Remove unnecessary private annotations. Cleanup: detach listeners from PRESTO instance. Allow presto instance to be null. * APP Move index.html to root folder. Add mux.js to support HLS playback. * TOOLING Add prepack script, this way it is easy to pack TGZ NPM packages for local use. The ESLint rule is getting miss-reported `@typescript-eslint/no-unsafe-assignment`, I'm not sure why, but let's just ignore it for now.
castlabs · Apr 8, 2024 · 88cb5a7 · 88cb5a7
1 parent 4807ad2
commit 88cb5a7
Show file tree

Hide file tree

Showing 30 changed files with 454 additions and 162 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -24,6 +24,7 @@ module.exports = {
     // <div onClick={(event: React.MouseEvent<HTMLButtonElement>) => event.altKey}}/>
     "@typescript-eslint/no-unsafe-call": "off",
     "@typescript-eslint/no-unsafe-member-access": "off",
+    "@typescript-eslint/no-unsafe-assignment": "off",
   },
   overrides: [
     {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,19 @@
+# 0.8.3 (Beta)
+
+## New Features
+
+* Add option to keep player controls hidden.
+* Make `BaseThemeOverlay` more configurable:
+  * Add option to hide buttons (audio, full screen, track options)
+  * Add option to hide the top bar of player controls
+  * Add option to render a companion component above the bottom bar
+    of player controls
+* Add option to display cues on the seek bar
+
+## Fixes
+
+* Fix rounding of duration.
+
 # 0.7.3 (Beta)
 
 ## Fixes

diff --git a/app/index.html b/app/index.html
@@ -0,0 +1,16 @@
+<!doctype html>
+<html lang="en">
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1" />
+  <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/[email protected]/dist/mux.js"></script>
+  <title>PRESTOplay React Components</title>
+</head>
+<body>
+  <noscript>
+    You need to enable JavaScript to run this app.
+  </noscript>
+  <div id="root"></div>
+  <script src="./dist/bundle.js"></script>
+</body>
+</html>
diff --git a/app/src/index.html b/app/src/index.html
diff --git a/package.json b/package.json
@@ -20,7 +20,8 @@
     "test:watch": "jest --watch",
     "lint": "npx eslint .",
     "storybook": "storybook dev --port 6006",
-    "build-storybook": "storybook build --output-dir ./dist/storybook"
+    "build-storybook": "storybook build --output-dir ./dist/storybook",
+    "prepack": "npm run build"
   },
   "license": "Apache-2.0",
   "devDependencies": {

diff --git a/scripts/rollup.config.app.mjs b/scripts/rollup.config.app.mjs
@@ -49,7 +49,7 @@ const options = [
         open: true,
         verbose: true,
         contentBase: ["", "app", "app/src"],
-        host: "0.0.0.0",
+        host: "localhost",
         port: "3000",
       }),
       livereload({