Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration cleanup from junit 4 to junit 5 #110

Merged
merged 58 commits into from
Nov 17, 2024

use Java21

0805dab
Select commit
Loading
Failed to load commit list.
Merged

add migration cleanup from junit 4 to junit 5 #110

use Java21
0805dab
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / PMD succeeded Nov 17, 2024 in 3s

20 new alerts

New alerts in code changed by this pull request

  • 20 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 614 in sandbox_common/src/org/sandbox/jdt/internal/common/LambdaASTVisitor.java

See this annotation in the file changed.

Code scanning / PMD

This if statement can be replaced by `return {condition} || {elseBranch};` Warning

This if statement can be replaced by return {condition};

Check warning on line 893 in sandbox_common/src/org/sandbox/jdt/internal/common/LambdaASTVisitor.java

See this annotation in the file changed.

Code scanning / PMD

Useless parentheses. Warning

Useless parentheses.

Check warning on line 313 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

See this annotation in the file changed.

Code scanning / PMD

Avoid unused method parameters such as 'holder'. Warning

Avoid unused method parameters such as 'importRewrite'.

Check warning on line 355 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

See this annotation in the file changed.

Code scanning / PMD

Avoid unused method parameters such as 'holder'. Warning

Avoid unused method parameters such as 'importRewrite'.

Check warning on line 366 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

See this annotation in the file changed.

Code scanning / PMD

Position literals first in String comparisons Warning

Position literals first in String comparisons

Check warning on line 575 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

See this annotation in the file changed.

Code scanning / PMD

Position literals first in String comparisons Warning

Position literals first in String comparisons

Check warning on line 657 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java

See this annotation in the file changed.

Code scanning / PMD

Position literals first in String comparisons Warning

Position literals first in String comparisons

Check warning on line 100 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleTemporayFolderJUnitPlugin.java

See this annotation in the file changed.

Code scanning / PMD

Position literals first in String comparisons Warning

Position literals first in String comparisons

Check warning on line 51 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java

See this annotation in the file changed.

Code scanning / PMD

Document empty constructor Warning

Document empty constructor

Check warning on line 69 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java

See this annotation in the file changed.

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead

Check warning on line 97 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java

See this annotation in the file changed.

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead

Check warning on line 104 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java

See this annotation in the file changed.

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead

Check warning on line 105 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java

See this annotation in the file changed.

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead

Check warning on line 47 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/preferences/cleanup/SandboxCodeTabPage.java

See this annotation in the file changed.

Code scanning / PMD

The local variable name 'vdf_initializer' doesn't match '[a-z][a-zA-Z0-9]*' Warning

The final local variable name 'junit_assert' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 50 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/preferences/cleanup/SandboxCodeTabPage.java

See this annotation in the file changed.

Code scanning / PMD

The local variable name 'vdf_initializer' doesn't match '[a-z][a-zA-Z0-9]*' Warning

The final local variable name 'junit_assume' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 53 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/preferences/cleanup/SandboxCodeTabPage.java

See this annotation in the file changed.

Code scanning / PMD

The local variable name 'vdf_initializer' doesn't match '[a-z][a-zA-Z0-9]*' Warning

The final local variable name 'junit_ignore' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 56 in sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/preferences/cleanup/SandboxCodeTabPage.java

See this annotation in the file changed.

Code scanning / PMD

The local variable name 'vdf_initializer' doesn't match '[a-z][a-zA-Z0-9]*' Warning

The final local variable name 'junit_test' doesn't match '[a-z][a-zA-Z0-9]*'

Check warning on line 14 in sandbox_junit_cleanup_test/src/org/eclipse/jdt/ui/tests/quickfix/Java8/JUnitMigrationCleanUpTest.java

See this annotation in the file changed.

Code scanning / PMD

Package name contains upper case characters Warning test

Package name contains upper case characters

Check warning on line 112 in sandbox_test_commons/src/org/sandbox/jdt/ui/tests/quickfix/rules/AbstractEclipseJava.java

See this annotation in the file changed.

Code scanning / PMD

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope Warning test

Unnecessary qualifier 'AbstractEclipseJava': 'addToClasspath' is already in scope

Check warning on line 113 in sandbox_test_commons/src/org/sandbox/jdt/ui/tests/quickfix/rules/AbstractEclipseJava.java

See this annotation in the file changed.

Code scanning / PMD

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope Warning test

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope