Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add migration cleanup from junit 4 to junit 5 #110

Merged
merged 58 commits into from
Nov 17, 2024
Merged

add migration cleanup from junit 4 to junit 5 #110

merged 58 commits into from
Nov 17, 2024

Conversation

carstenartur
Copy link
Owner

@carstenartur carstenartur commented Oct 12, 2024 •
edited
Loading

Cleanup to migrate Tests to JUnit5

At the time being only a subset of all possible apis of JUnit is supported.

  • Assert -> Assertions
  • Test -> Test
  • Rule Temporary Folder
  • Rule Testname
  • ExternalResource
  • @Before, @After
  • @BeforeClass, @AfterClass

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java
/**
*
*/
public JUnitCleanUpCore() {

Check warning

Code scanning / PMD

Document empty constructor Warning

Document empty constructor
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java
if (compilationUnit == null) {
return null;
}
EnumSet<JUnitCleanUpFixCore> computeFixSet= computeFixSet();

Check warning

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java
throw new AbortSearchException();
}
if (typeBinding.isArray()) {
typeBinding= typeBinding.getElementType();

Check notice

Code scanning / Pmd (reported by Codacy)

Avoid reassigning parameters such as 'typeBinding'

Avoid reassigning parameters such as 'typeBinding'
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup_test/src/org/sandbox/jdt/ui/tests/quickfix/Java8CleanUpTest.java Fixed Show fixed Hide fixed
@carstenartur carstenartur force-pushed the addjunitskeleton branch 2 times, most recently from 7de4607 to e000d49 Compare October 13, 2024 10:25
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 13, 2024
View reviewed changes
sandbox_common/src/org/sandbox/jdt/internal/common/LambdaASTVisitor.java
return true;
}
}
return ((BiPredicate<SingleMemberAnnotation, E>) (this.helperVisitor.predicatemap.get(VisitorEnum.SingleMemberAnnotation))).test(node, this.helperVisitor.dataholder);

Check warning

Code scanning / PMD

Useless parentheses. Warning

Useless parentheses.
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/IgnoreJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/JunitHolder.java Fixed Show fixed Hide fixed
@carstenartur carstenartur changed the title add skeleton with only renamings add migration cleanup from junit 4 to junit 5 Oct 13, 2024
@carstenartur carstenartur mentioned this pull request Oct 18, 2024
Draft
3 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2024
View reviewed changes
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2024
View reviewed changes
sandbox_common/src/org/sandbox/jdt/internal/common/LambdaASTVisitor.java
if (typeBinding.getQualifiedName().equals(qualifiedname)) {
return true;
}
typeBinding = typeBinding.getSuperclass();

Check notice

Code scanning / Pmd (reported by Codacy)

Avoid reassigning parameters such as 'typeBinding'

Avoid reassigning parameters such as 'typeBinding'
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleJUnitPlugin.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2024
View reviewed changes
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...it_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleTemporayFolderJUnitPlugin.java
method.accept(new ASTVisitor() {
@Override
public boolean visit(MethodInvocation node) {
if (node.getName().getIdentifier().equals("newFile")) {

Check warning

Code scanning / PMD

Position literals first in String comparisons Warning

Position literals first in String comparisons
...ox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleTestnameJUnitPlugin.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2024
View reviewed changes
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2024
View reviewed changes
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
..._cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/AbstractTool.java Outdated
if (ORG_JUNIT_RULES_EXTERNAL_RESOURCE.equals(typeBinding.getQualifiedName())) {
return true;
}
typeBinding = typeBinding.getSuperclass();

Check notice

Code scanning / Pmd (reported by Codacy)

Avoid reassigning parameters such as 'typeBinding'

Avoid reassigning parameters such as 'typeBinding'
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2024
View reviewed changes
...unit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/ExternalResourceJUnitPlugin.java Fixed Show fixed Hide fixed
...ox_junit_cleanup/src/org/sandbox/jdt/internal/corext/fix/helper/RuleTestnameJUnitPlugin.java Fixed Show fixed Hide fixed
sandbox_junit_cleanup/src/org/sandbox/jdt/internal/ui/fix/JUnitCleanUpCore.java
@Override
public String getPreview() {
StringBuilder sb= new StringBuilder();
EnumSet<JUnitCleanUpFixCore> computeFixSet= computeFixSet();

Check warning

Code scanning / PMD

Avoid using implementation types like 'Stack'; use the interface instead Warning

Avoid using implementation types like 'EnumSet'; use the interface instead
@carstenartur carstenartur mentioned this pull request Nov 13, 2024
Open
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 17, 2024
View reviewed changes
sandbox_test_commons/src/org/sandbox/jdt/ui/tests/quickfix/rules/AbstractEclipseJava.java
IJavaProject fProject = getJavaProject();
fProject.setRawClasspath(getDefaultClasspath(), null);
IClasspathEntry cpe= JavaCore.newContainerEntry(junitContainerPath);
AbstractEclipseJava.addToClasspath(fProject, cpe);

Check warning

Code scanning / PMD

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope Warning test

Unnecessary qualifier 'AbstractEclipseJava': 'addToClasspath' is already in scope
sandbox_test_commons/src/org/sandbox/jdt/ui/tests/quickfix/rules/AbstractEclipseJava.java
fProject.setRawClasspath(getDefaultClasspath(), null);
IClasspathEntry cpe= JavaCore.newContainerEntry(junitContainerPath);
AbstractEclipseJava.addToClasspath(fProject, cpe);
fSourceFolder= AbstractEclipseJava.addSourceContainer(fProject, "src");

Check warning

Code scanning / PMD

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope Warning test

Unnecessary qualifier 'AbstractEclipseJava': 'addSourceContainer' is already in scope
@carstenartur carstenartur merged commit 146c0ff into main Nov 17, 2024
6 checks passed
@carstenartur carstenartur deleted the addjunitskeleton branch November 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carstenartur