Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ssh client package required by maven release plugin #482

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

timothystone
Copy link

Consume upstream changes from dacr repository. Branch, resolve conflicts, and add openssh-clients to new images using appropriate package manager.

Update README SSH column.

Fixes #378

@timothystone
Copy link
Author

Replaces #480

Consume upstream changes from dacr repository. Branch, resolve conflicts, and add openssh-clients to
new images using appropriate package manager.

Update README SSH column.

Assert success on openssh-client availability.

Fixes carlossg#378
@timothystone-knsl timothystone-knsl force-pushed the feat/iss-378-ssh-clients branch from 635dce3 to fe5e53b Compare July 18, 2024 18:53
@timothystone-knsl
Copy link
Contributor

h/t @dacr for the initial work. To collaborate with the upstream, recreated PR and rebased on new fork. Credit where credit is due. Thanks @dacr!

@timothystone
Copy link
Author

Ready for workflows. 🙏

@carlossg carlossg merged commit 28f64b6 into carlossg:main Jul 19, 2024
65 checks passed
@carlossg
Copy link
Owner

thanks!

@timothystone timothystone deleted the feat/iss-378-ssh-clients branch July 19, 2024 15:59
@timothystone-knsl
Copy link
Contributor

@carlossg when does a change like this land in Docker Hub? And thanks for your patience and guidence in the PRs.

@carlossg
Copy link
Owner

I was thinking about not pushing this to dockerhub official images until there is a maven new version so it is not surprising existing users. It can be downloaded from my dockerhub and github regesitries already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest images don't have ssh causing maven-release-plugin to fail
3 participants