-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ssh client package needed by maven release plugin #480
feat: add ssh client package needed by maven release plugin #480
Conversation
thanks, I don't have permission to update the PR, can you change the line |
liberica is failing
|
@carlossg Liberica failures in CentOS only. Looks related to this comment on ServerFault. Looking at path to resolution. Working on it. |
@carlossg so it appears that Liberica has not updated the CentOS images in three months. That's fine... I guess. But this change appears to about two weeks old and Liberica may drop a change. I'll try to monitor it. I've got a patch inbound for your review based on the idea proposed in the ServerFault comment. Going to test it locally, then push. |
It's far more complicated. Liberica CentOS distros are building from 7.9.2009 which is EOL and not getting security updates. How does the project determine removal of build support when upstream projects get stale? |
I'll remove them |
Do you want me to remove them from PR, or is there another process to handle post PR merge? |
when #481 is merged you'll need to rebase and solve conflicts |
Working on the update. |
Ready to kick off the workflows I think. |
I could use this patch. Definitely +1 for it being migrated in |
@timothystone could you allow maintainers edits to the PR as I'd like to squash this into one commit and rebase it? |
Of course. Working on it.
[image deleted] D'oh, my upstream is not this repository. Let me fix that (I'll make you a Collaborator for the moment). Made you a collaborator for the time being. Some background, I forked from David's original fork. David opened his PR from Update Helping out here. There's an invite to the project in your mailbox. I'm rebasing through the |
Update README with images supporting ssh client
Consume upstream changes from dacr repository. Branch, resolve conflicts, and add openssh-clients to new images using appropriate package manager. Update README SSH column. Assert SSH is present. Fixes carlossg#378
17f13c9
to
32910c1
Compare
I can recreate on a "properly forked" repository if necessary. Sorry for the mess and overhead. |
Closing. See #482. |
Consume upstream changes from dacr repository. Branch, resolve conflicts, and add openssh-clients to
new images using appropriate package manager.
Update README SSH column.
Fixes #378