Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons-react): use declare keyword in bucket TypeScript types #15094

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix(icons-react): use declare keyword in bucket TypeScript types #15094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/icon-build-helpers/src/builders/react/next/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ async function writeBucketTypes(buckets, outDir) {
for (const bucket of buckets) {
const iconLines = [];
for (const m of bucket.modules) {
iconLines.push('export const ' + m.name + ': CarbonIconType;');
iconLines.push('declare const ' + m.name + ': CarbonIconType;');
}
const bucketModule = `generated/${bucket.id}`;
const filepath = path.resolve(outDir, `${bucketModule}.d.ts`);
Expand All @@ -66,7 +66,7 @@ async function writeBucketTypes(buckets, outDir) {
'\n' +
"import type { CarbonIconType } from '../CarbonIcon';\n" +
iconLines.join('\n') +
'\n';
`\nexport { ${bucket.modules.map((m) => m.name).join(', ')} };\n`;
await fs.writeFile(filepath, content);
}
}
Expand Down
Loading