fix(icons-react): use declare keyword in bucket TypeScript types #15094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreancardona this should fix the problem you spotted. I'm not 100% sure it's the right or complete solution though, since I weren't able to reproduce this problem in my TS projects. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@alisonjoseph meant to tag you, sorry. |
alisonjoseph
approved these changes
Nov 2, 2023
tay1orjones
approved these changes
Nov 3, 2023
Merged
via the queue into
carbon-design-system:main
with commit Nov 3, 2023
0889f3c
16 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix TypeScript compilation problem reported in carbon-design-system/carbon-website#3787 (comment).
Changelog
Changed
Testing / Reviewing
The TypeScript typed code using icons-react should compile without issues.