Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): update carbon and gatsby-theme-carbon deps #3787

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore(release): update carbon and gatsby-theme-carbon deps #3787

merged 1 commit into from
Nov 15, 2023

Conversation

carbon-automation[bot]
Copy link
Contributor

Automated pull request to update Carbon and gatsby-theme-carbon on the website
Checklist

  • Verify package version bumps are accurate
  • Verify CI passes as expected
  • Verify no regressions on the website in the deploy preview

@carbon-automation carbon-automation bot requested review from a team as code owners October 27, 2023 20:49
@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 8:26pm

@alisonjoseph

This comment was marked as outdated.

Sign in to view
@tay1orjones
Copy link
Member

I'm working on a new release that should fix both of those issues

@tay1orjones tay1orjones mentioned this pull request Nov 1, 2023
Closed
@carbon-automation carbon-automation bot force-pushed the release/update-carbon-deps branch from 288b332 to e1652f9 Compare November 1, 2023 17:33
@carbon-automation carbon-automation bot force-pushed the release/update-carbon-deps branch from e1652f9 to b75cecc Compare November 1, 2023 18:31
@alisonjoseph
Copy link
Member

alisonjoseph commented Nov 1, 2023 •
edited
Loading

Still failing after update to 1.4.2
Screenshot 2023-11-01 at 1 53 11 PM

@alisonjoseph alisonjoseph mentioned this pull request Nov 2, 2023
Merged
@lewandom lewandom mentioned this pull request Nov 2, 2023
Merged
@tay1orjones
Copy link
Member

@lewandom We've updated this PR to test the latest RC release published yesterday that contains all the recent fixes for types in @carbon/icons-react. We're still seeing some failures here.

image

The same error happens with Boolean, DataView, Error, Function, and Map.

Looking on unpkg I can see the difference in output (newest on the left):
image

Is the importing of Icon necessary? Could it relate to these errors?

The index now imports the iconProptypes file

image

and the contents of that file is quite different

image

These are just a few things I noticed that changed when sifting through the output.

@lewandom lewandom mentioned this pull request Nov 8, 2023
Merged
@carbon-automation carbon-automation bot force-pushed the release/update-carbon-deps branch from 7cc7ffd to 967e1a8 Compare November 13, 2023 21:03
@tay1orjones tay1orjones mentioned this pull request Nov 15, 2023
Merged
@carbon-automation carbon-automation bot force-pushed the release/update-carbon-deps branch from 967e1a8 to 4fc3b08 Compare November 15, 2023 20:12
tay1orjones
tay1orjones approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 😮‍💨

alisonjoseph
alisonjoseph approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tay1orjones tay1orjones merged commit 2be780a into main Nov 15, 2023
7 checks passed
@tay1orjones tay1orjones deleted the release/update-carbon-deps branch November 15, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

@kingtraceyj kingtraceyj Awaiting requested review from kingtraceyj kingtraceyj is a code owner automatically assigned from carbon-design-system/design

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisonjoseph @tay1orjones