fix(react): publish type definitions for @carbon/react/icons #15086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Nov 2, 2023
|
@lewandom will this fix this error I'm seeing in our website? carbon-design-system/carbon-website#3787 |
|
@alisonjoseph no, that seems to be yet another, different problem with the types I added for icons-react. |
tay1orjones
approved these changes
Nov 2, 2023
Merged
via the queue into
carbon-design-system:main
with commit Nov 2, 2023
abd0f86
17 checks passed
|
@lewandom do you know what the issue is, is it something you can easily open a PR for to fix? It's also breaking the design language website. |
|
@alisonjoseph I think I know what the issue is, trying to come up with a fix just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript types were added to
@carbon/react/iconsin #14714, but are not consumable, cause...index.d.tsis not being published... Oops.Changelog
New
icons/index.d.tsto the list of files published by@carbon/react.Testing / Reviewing
Can only test after this change is released. After it's released, should be able to use TypeScript types for icons.