-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use uv tool run for pre-commit if not global #300
base: main
Are you sure you want to change the base?
Conversation
I'm not entirely sure what the intended result for pre-commit is, but I think my host env is too dirtied at this point to replicate the original conditions. I:
When I ran Then, when I re-ran sudo snap install --classic astral-uv
astral-uv 0.5.7 from Alex Lowe (lengau) installed
uv tool install pre-commit
uv tool run pre-commit install
`pre-commit` is already installed
pre-commit installed at .git/hooks/pre-commit
uv sync --frozen --all-extras Is the bit about "already installed" wrong? Should it be installing as a script in |
@medubelko |
pre-commit is completely absent from my system at this point, which is why I'm confused about why the log says I have it. |
uv still had pre-commit installed as a tool, so I think it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I'm not confident in my own testing of this.
Issue found here: canonical/craft-store#241 (review)
tox
?