chore: move tests to starflow #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/starflow
branch
5 times, most recently
from
3ab0b70 to
f715a08
Compare
lengau
force-pushed
the
work/starflow
branch
2 times, most recently
from
0353773 to
a19f2dc
Compare
|
Is the practice we are adopting to use lock files in our libraries? Is this mostly for us? |
sergiusens
reviewed
Dec 13, 2024
sergiusens
approved these changes
Dec 13, 2024
medubelko
reviewed
Dec 13, 2024
There was a problem hiding this comment.
When I ran make setup, I ran into:
warning: `/home/medubelko/.local/bin` is not on your PATH. To use installed tools, run `export PATH="/home/medubelko/.local/bin:$PATH"` or `uv tool update-shell`.
/bin/sh: 2: pre-commit: not found
make: *** [common.mk:62: setup-precommit] Error 127Since this blocks tests until I run uv tool ..., is this something we should add to the setup command, or document it?
When I tried to fix it, make setup resulted in:
uv tool install pre-commit
pre-commit install
`pre-commit` is already installed
/bin/sh: 2: pre-commit: not found
make: *** [common.mk:62: setup-precommit] Error 127The docs build OK, minus we're missing the shared resources, but that's out of scope for this PR.
3 tasks
lengau
added a commit
to canonical/starbase
that referenced
this pull request
Dec 13, 2024
3 tasks
|
@medubelko could you try the fix at canonical/starbase#300? |
lengau
force-pushed
the
work/starflow
branch
from
38a6bfb to
b6c5b53
Compare
medubelko
approved these changes
Dec 13, 2024
Includes adding constraints to lowest-deps works.
lengau
force-pushed
the
work/starflow
branch
from
cee4eab to
7399526
Compare
Switching to the starbase Makefile also swaps black for ruff.
lengau
force-pushed
the
work/starflow
branch
from
7399526 to
1cc50d2
Compare
lengau
added a commit
to canonical/starbase
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be easiest to review per-commit, since there's a big autoformat in the middle that changes a lot of files.
make lint && make test?