Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always refresh metrics endpoint reldata on update-status #385

Closed
wants to merge 2 commits into from
Closed

Always refresh metrics endpoint reldata on update-status #385

wants to merge 2 commits into from

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Oct 13, 2022

Issue

Solution

Add self._set_scrape_job_spec as an observer to update-status.

Fixes #368.

Drawbacks

The user would have to wait for the update-status hook interval to elapse.

Context

This is an alternative to #384.

Testing Instructions

Release Notes

Always refresh metrics endpoint reldata on update-status.

@sed-i sed-i mentioned this pull request Oct 13, 2022
Merged
@sed-i sed-i mentioned this pull request Oct 13, 2022
Closed
@sed-i
Copy link
Contributor Author

sed-i commented Oct 13, 2022

#384 is probably the better solution. Closing this one.

@sed-i sed-i closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

External hostname is not updated if an ingress is added *after* relating a charm to Prometheus
1 participant
@sed-i