Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics endpoint relation data every re-init #384

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Oct 13, 2022

Issue

Solution

Call self._set_scrape_job_spec in __init__ to update app data every charm re-init.

Fixes #368.

Drawbacks

Adds unnecessary comms with juju.

Context

Testing Instructions

Release Notes

@sed-i sed-i marked this pull request as ready for review October 13, 2022 15:19
@sed-i sed-i merged commit 407806c into main Oct 13, 2022
@sed-i sed-i deleted the feature/fix-ingress-metrics branch October 13, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External hostname is not updated if an ingress is added *after* relating a charm to Prometheus
3 participants