Update metrics endpoint relation data every re-init #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ready_for_unit
is emitted too early traefik-k8s-operator#78 is fixed, but also introduces additional friction for the user to remember to pass custom refresh events.Solution
Call
self._set_scrape_job_spec
in__init__
to update app data every charm re-init.Fixes #368.
Drawbacks
Adds unnecessary comms with juju.
Context
Testing Instructions
Release Notes