24 Support shim fallback bootchain #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Calder <[email protected]>
Signed-off-by: Oliver Calder <[email protected]>
Signed-off-by: Oliver Calder <[email protected]>
Signed-off-by: Oliver Calder <[email protected]>
There was a problem hiding this comment.
Looks great, some comments though:
- Looks like the right time to remove shim from the boot partition (it has never been used)
- 2.61 might be too optimistic
See also comment below.
In any case, the PR cannot be merged until a snapd version with support for this has landed.
| install -m 644 "$shim_path" "$CRAFT_PART_INSTALL"/shim.efi.signed | ||
| install -m 644 "$grub_path" "$CRAFT_PART_INSTALL"/${grub_bin%.signed} | ||
| install -m 644 "$fb_path" "$CRAFT_PART_INSTALL"/$fb_bin | ||
| install -m 644 "$mm_path" "$CRAFT_PART_INSTALL"/$mm_bin | ||
| install -m 644 "$csv_path" "$CRAFT_PART_INSTALL"/$boot_csv |
There was a problem hiding this comment.
Maybe time to make this a for loop
As it is not really used at all from there. Signed-off-by: Oliver Calder <[email protected]>
|
This PR is being taken over by @valentindavid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the EFI boot assets to place shim and grub binaries in
EFI/ubuntu/, with boot and fallback binaries inEFI/BOOT/. Additionally,BOOT${arch}.CSVandmm${arch}.efiare placed inEFI/ubuntu/.This corresponds to work being done in snapd to support shim fallback: canonical/snapd#13205
This corresponds to PR #106 , and is designed to be eventually backported to branches 22 and 20.
The possible boot patterns are:
EFI/ubuntu/shim${arch}.efi).EFI/BOOT/fb${arch}.efiis run, which searches forBOOT${arch}.CSV, finds it inEFI/ubuntu/, and thus boots the corresponding assets inEFI/ubuntu/.EFI/BOOT/BOOT${arch}.efi.