Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gadget: use new boot chain #113

Merged

Conversation

valentindavid
Copy link
Collaborator

@valentindavid valentindavid commented Apr 4, 2024

pc-gadget provides the shim boot chain for removable media. This is not the proper boot chain for an installed system.

The difference between boot chains is explained upstream: https://github.com/rhboot/shim/blob/main/README.fallback

This does not introduce the MOK manager yet.

This depends on snapd 2.63 because downgrade would require removing EFI/boot/fbx64.efi.

Depends on:

@alfonsosanchezbeato
Copy link
Member

Is this equivalent to #107 , I assume?

@valentindavid valentindavid force-pushed the valentindavid/new-boot-chain branch from 8c27762 to 0e125d4 Compare June 24, 2024 11:47
@valentindavid valentindavid marked this pull request as ready for review June 24, 2024 12:02
@valentindavid
Copy link
Collaborator Author

Is this equivalent to #107 , I assume?

Yes.

@valentindavid
Copy link
Collaborator Author

Though the difference is this does not add the mokmanager.

pc-gadget provides the shim boot chain for removable media. This
is not the proper boot chain for an installed system.

The difference between boot chains is explained upstream:
https://github.com/rhboot/shim/blob/main/README.fallback

This does not introduce the MOK manager yet.

This depends on snapd 2.63 because downgrade would require removing
`EFI/boot/fbx64.efi`.
Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, I think we need a "assumes" on the version of snapd that supports this before merging.

@valentindavid
Copy link
Collaborator Author

But, I think we need a "assumes" on the version of snapd that supports this before merging.

It should already be there because of #116

@valentindavid valentindavid merged commit e5be435 into canonical:24 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants