Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Dqlite remove endpoint for cleanup (KU-1719) #69

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

HomayoonAlimohammadi
Copy link

Overview

This PR adds the logic to call the dqlite/remove endpoint upon node removal specifically to address issues with duplicate endpoints being found in the dqlite cluster when a new node is trying to join (and it's been allocated an IP which belonged to a now deleted node).

PRs regarding this feature:

@HomayoonAlimohammadi HomayoonAlimohammadi changed the title Call Dqlite remove endpoint for cleanup (KU-1786) Call Dqlite remove endpoint for cleanup (KU-1719) Oct 11, 2024
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit ac3d9e3 into main Oct 14, 2024
4 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the dqlite-remove-endpoint branch October 14, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants