Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capi-auth-token file to control plane machines #115

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

HomayoonAlimohammadi
Copy link

@HomayoonAlimohammadi HomayoonAlimohammadi commented Oct 9, 2024

Summary

This PR adds the /capi/etc/token file with a random token to the control plane machines.

PR series

  1. Cluster agent token validation --> validate capi-auth-token on dqlite/remove microk8s-cluster-agent#56
  2. Microk8s bootstrap provider add token file and secret --> This one
  3. Microk8s control plane provider use token for request --> Add capi-auth-token header to /dqlite/remove request cluster-api-control-plane-provider-microk8s#68
  4. Merging dqlite-remove-endpoint feature branch to main:
    a. cluster-agent: Add Dqlite remove endpoint (KU-1719) microk8s-cluster-agent#57
    b. control-plane provider: Call Dqlite remove endpoint for cleanup (KU-1719) cluster-api-control-plane-provider-microk8s#69

Copy link

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, looking good otherwise.

controllers/cloudinit/controlplane_init.go Outdated Show resolved Hide resolved
pkg/token/token.go Outdated Show resolved Hide resolved
Copy link

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need to wait for dependent PR before merge.

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit f60ac2e into main Oct 14, 2024
4 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the KU-1719/add-auth-token-secret branch October 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants