Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(24.10): add python3-pip slices #428

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat(24.10): add python3-pip slices #428

merged 3 commits into from
Dec 16, 2024

Conversation

rebornplusplus
Copy link
Member

@rebornplusplus rebornplusplus commented Dec 12, 2024 •
edited
Loading

Adds the python3-pip slices and dependencies in 24.10.

Forward-port of #356

Key difference:

  • The python3-setuptools slices are not ported for two reasons:
    1. It is not a requirement of python3-pip anymore.
    2. The dependency chain of python3-setuptools is big enough in 24.10 for it to be added in its own PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Diff of dependencies:
None found.

@rebornplusplus rebornplusplus marked this pull request as ready for review December 13, 2024 13:21
@rebornplusplus rebornplusplus mentioned this pull request Dec 13, 2024
Merged
clay-lake
clay-lake approved these changes Dec 16, 2024
View reviewed changes
Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

cjdcordeiro
cjdcordeiro approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for porting ;)

@cjdcordeiro cjdcordeiro merged commit e087728 into canonical:ubuntu-24.10 Dec 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clay-lake clay-lake clay-lake approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebornplusplus @cjdcordeiro @clay-lake