Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add python3-pip slices #356

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

rebornplusplus
Copy link
Member

This PR adds the python3-pip slices and it's dependencies.

Copy link

github-actions bot commented Oct 1, 2024

Diff of dependencies:
None found.


@rebornplusplus rebornplusplus marked this pull request as ready for review October 1, 2024 17:30
@rebornplusplus rebornplusplus added the Priority Look at me first label Oct 1, 2024
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(discussed offline - it would be nice to have python version-specific slices)

This slice comes with python3.12 installed.
@linostar linostar self-requested a review October 16, 2024 11:39
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rebornplusplus
Copy link
Member Author

@cjdcordeiro please take another look when you are free. :)

@clay-lake
Copy link

As per chisel-releases PR extravaganza: We are going to create a python3 SDF which links to python3.12 in the case of 24.04, then include python3_minimal to the pip3_bins slice so it works out of the box.

@linostar linostar self-requested a review November 12, 2024 10:27
Copy link

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once #387 is merged, use python3_standard as a dependency instead of python3.12-standard.
Also remove bins slice from python3-pip and rename bins3-12 slice to become bins.

@cjdcordeiro cjdcordeiro added the Blocked Waiting for something external label Nov 18, 2024
@norrisjeremy
Copy link

When will this slice be merged?

@linostar
Copy link

This is no longer blocked since #387 got merged.

@linostar linostar removed the Blocked Waiting for something external label Dec 11, 2024
@rebornplusplus
Copy link
Member Author

Thanks for the nudge @norrisjeremy. The PR is updated.

Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your patience! @norrisjeremy
@cjdcordeiro

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@cjdcordeiro cjdcordeiro merged commit e7a2ccf into canonical:ubuntu-24.04 Dec 11, 2024
14 checks passed
@norrisjeremy
Copy link

Will this also be forward-ported into 24.10?

@cjdcordeiro
Copy link
Collaborator

Yes, @rebornplusplus will be raising that soon

@norrisjeremy
Copy link

Is there a reason why there isn't a python3-venv slice?

@rebornplusplus
Copy link
Member Author

Is there a reason why there isn't a python3-venv slice?

I reckon it wasn't needed so far by anyone. Please feel free to raise a PR.

@rebornplusplus
Copy link
Member Author

Will this also be forward-ported into 24.10?

Raised #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants