-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add python3-pip slices #356
feat(24.04): add python3-pip slices #356
Conversation
Diff of dependencies: |
085d712
to
f913ef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(discussed offline - it would be nice to have python version-specific slices)
This slice comes with python3.12 installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cjdcordeiro please take another look when you are free. :) |
As per chisel-releases PR extravaganza: We are going to create a python3 SDF which links to python3.12 in the case of 24.04, then include python3_minimal to the pip3_bins slice so it works out of the box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #387 is merged, use python3_standard
as a dependency instead of python3.12-standard
.
Also remove bins
slice from python3-pip and rename bins3-12
slice to become bins
.
When will this slice be merged? |
This is no longer blocked since #387 got merged. |
Thanks for the nudge @norrisjeremy. The PR is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your patience! @norrisjeremy
@cjdcordeiro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Will this also be forward-ported into 24.10? |
Yes, @rebornplusplus will be raising that soon |
Is there a reason why there isn't a |
I reckon it wasn't needed so far by anyone. Please feel free to raise a PR. |
Raised #428. |
This PR adds the
python3-pip
slices and it's dependencies.