feat(24.04): add erlang slices #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff of dependencies: slices/erlang-base.yaml@@ -1,8 +1,9 @@
-adduser
+bash
+coreutils
libc6
libgcc-s1
+libreadline8t64
libstdc++6
libsystemd0
libtinfo6
-procps
zlib1g |
linostar
requested review from
ROCKsBot and
a team
and removed request for
ROCKsBot
This was referenced Nov 8, 2024
rebornplusplus
requested changes
Nov 13, 2024
zhijie-yang
reviewed
Nov 14, 2024
There was a problem hiding this comment.
It looks to me overall good, except that we are having issues testing the snmpc. We need to either work it out, or provide with necessary justifications why we are not testing it with the spread tests. Wdyt, @cjdcordeiro ?
|
@zhijie-yang what's the issue? I can't find it from the previous comments. Is it what's described in the PR description? |
cjdcordeiro
requested changes
Nov 18, 2024
|
The missing test for snmpc was added. |
cjdcordeiro
added a commit
that referenced
this pull request
Nov 21, 2024
This reverts commit 6ba20f9.
cjdcordeiro
added a commit
that referenced
this pull request
Nov 21, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add erlang-* slices to 24.04
Note that erlang packages are not available for i386 arch.
I tried to add tests for all erlang binaries , but some of them needs the erl server to be running in the background, and attempting to run it with
&or withnohuphas failed in the spread container (although it works locally).Related issues/PRs
PR #258
Forward porting
N/A
Checklist
Additional Context
N/A