-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): add erlang slices #394
feat(24.04): add erlang slices #394
Conversation
Diff of dependencies: slices/coreutils.yaml@@ -1,6 +1,8 @@
libacl1
libattr1
libc6
+libcrypt1
+libgcc-s1
libgmp10
+libpcre2-8-0
libselinux1
-libssl3t64 slices/erlang-base.yaml@@ -1,8 +1,8 @@
-adduser
+bash
+coreutils
libc6
libgcc-s1
libstdc++6
libsystemd0
libtinfo6
-procps
zlib1g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up from #384 (comment)
bash is needed because there are several erlang packages that have shell scripts, and they all depend on erlang-base, so it makes sense to put bash as dependency in erlang-base.
coreutils is needed because some bash scripts use /usr/bin/env to detect the path of escript, and env is found in coreutils
as for libtinfo8t64, I found that some of the binaries in erlnag-snmp are trying to open libtinfo so file (from strace output), and I am not sure if there are others that use it as well, so I put it in erlang-base's essential as a precaution.
What are the several erlang packages that have shell scripts? If those are other than the erlang-base
, then those should be the ones carrying this bash
dependency.
For coreutils
, same as for bash
. Additionally, if all you need is env
, then let's not bring in all the binaries.
And libtinfo8t64
, adding it just as a precaution isn't a good practice cause we may be unnecessarily bloating the slice, and once introduced, it's not something we can delete (not at least until the following Ubuntu release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just missing a test and that would be it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Proposed changes
Add erlang-* slices to 24.04
Note that erlang packages are not available for i386 arch.
I tried to add tests for all erlang binaries , but some of them needs the erl server to be running in the background, and attempting to run it with
&
or withnohup
has failed in the spread container (although it works locally).Related issues/PRs
PR #258
Forward porting
N/A
Checklist
Additional Context
N/A