-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(23.10): add archive for curl and its dependencies #127
Conversation
feat(23.10): add new archive for libpsl5, libunistring2, libidn2-0
…tls30,libgpg-error0,libhogweed6,libldap-2.5-0,libnettle8,libnghttp2-14,librtmp1,libssh2-1
@cjdcordeiro gentle review reminder! |
@cjdcordeiro Do you see a point in a tool like this? |
this is interesting @yashashwi :) We'll be working, in the future, on expanding chisel to have additional tooling to help both the inspection and creation of slices. The slice inspection and discoverability features are already being proposed in canonical/chisel#99 and canonical/chisel#101. The assisted creation of slices shall come later, but it is extremely refreshing to see the community coming up with their own solutions :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Just a few nitpicks and a leftover SDF to fix
@cjdcordeiro Fixed review comments. |
@cjdcordeiro review pending. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated already
@rebornplusplus could you please review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one dependency seems to be wrong. Everything else looks very good. Thank you!
removed incorrect dependency Co-authored-by: Rafid Bin Mostofa <[email protected]>
@rebornplusplus fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@cjdcordeiro review pending. |
@cjdcordeiro could you please review this PR. |
Hi @yashashwi apologies for the delay but we've been working on some high priority CI checks that are a must for all the pending PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing CLA check
Yeah some of the initial commits have been as the root user. It seems I have to recommit all of it and re raise the PR. Np! I understand you are occupied. |
Closed in favor of #186 |
No description provided.