feat(22.04): add archive curl, libcurl4, libgcrypt20, libgpg-error0, libnhttp2-14, librtmp1, libssh2-1, libzstd1, libpsl5

[ghost]

Libpsl allows checking domains against the Public Suffix List. It can be used to avoid privacy-leaking 'super-cookies', 'super domain' certificates, for domain highlighting purposes sorting domain lists by site and more.

Refer below package list for dependencies list
https://packages.ubuntu.com/jammy/libs/libpsl5

---

Forward-port PRs

• 23.10: feat(23.10): add archive for curl and its dependencies #127
• 24.04: feat(24.04): add slices for curl and its dependencies #133

[ghost]

@cjdcordeiro , @rebornplusplus ,@letFunny
May I know who to assign this PR for review?

[cjdcordeiro]

Thanks for the PR @yashashwi . We'll review it shortly. In the meantime, you might want to update your branch with the latest changes.

Can you please also create the corresponding PRs for 23.10 and 24.04? Thanks :)

[rebornplusplus]

Looks good to me, thanks. Left a nitpick comment only.

[ghost]

@cjdcordeiro This change cannot directly go to 23.10 and 24.04, because we don't have libidn2-0_libs
- libunistring2_libs, in those upstreams.
Will raise PR in some time with all nested libraries till libpsl5 for 23.10 and 24.04.

[cjdcordeiro]

Cool. Thanks @yashashwi . We'll then hold this until those PRs are up, but it LGTM ;)

[ghost]

@cjdcordeiro
I have raised the PR for ubuntu-23.10- [https://github.com//pull/107]
For Ubuntu:24.04 some of the slices like libunistring2 are not in the archive of noble. Therefore not raising the PR for 24.04

Refer below exception:
2024/02/01 15:51:09 Fetching index for ubuntu 24.04 noble-updates universe component...
error: slice package "libunistring2" missing from archive

[rebornplusplus]

@cjdcordeiro I have raised the PR for ubuntu-23.10- [https://github.com//pull/107] For Ubuntu:24.04 some of the slices like libunistring2 are not in the archive of noble. Therefore not raising the PR for 24.04

Refer below exception: 2024/02/01 15:51:09 Fetching index for ubuntu 24.04 noble-updates universe component... error: slice package "libunistring2" missing from archive

libpsl5 depends on libunistring5 actually.

[ghost]

@cjdcordeiro I have raised the PR for ubuntu-23.10- [https://github.com//pull/107] For Ubuntu:24.04 some of the slices like libunistring2 are not in the archive of noble. Therefore not raising the PR for 24.04
Refer below exception: 2024/02/01 15:51:09 Fetching index for ubuntu 24.04 noble-updates universe component... error: slice package "libunistring2" missing from archive

libpsl5 depends on libunistring5 actually.

@rebornplusplus yes it depends on that,
1.what does this exception mean - missing from archive. ?
2. Am I good to merge this PR for now, since this PR is for JAmmy.

[ghost]

The ultimate aim was to push curl bin, and since the PR was yet to be merged- I added complete package for Curl to execute.
Kindly re-review.
@cjdcordeiro @rebornplusplus @niemeyer

[ghost]

Thanks for the changes @yashashwi .

It's working well. Let's skip 24.04 if it cannot be done atm.

Once @rebornplusplus 's comments are addressed and 23.10's PR ready for review, this can be merged ;)

@cjdcordeiro I tried to raise the similar PR with curl for 23.10, but there are certain dependencies which does not have archive available for them in 23.10, Hence cannot raise the PR for 23.10.

I think PR #114 is sufficient for now. Lets merge PR 114 and this PR. Meanwhile is there any document that discusses how to update the archive, would like to update the same for 23.10 and 24.04

[cjdcordeiro]

ty! lgtm

[ghost]

accidently @cjdcordeiro review is requested again. No change in the PR.

[cjdcordeiro]

Np, but while reviewing #114 and the claim on incompatibility with 24.04 I realized that there are slices in this PR that can be ported to newer releases:

• curl
• libcurl4
• libgpg-error0
• libgcrypt20
• libnghttp2-14
• librtmp1
• libssh2-1
• libzstd1

NOTE: I know that the ultimate goal is to have curl, but if it helps to merge libpsl5 as soon as possible, feel free to move the above SDFs to a separate PR, keeping this PR focused on libpsl5 only

[ghost]

Np, but while reviewing #114 and the claim on incompatibility with 24.04 I realized that there are slices in this PR that can be ported to newer releases:

• curl
• libcurl4
• libgpg-error0
• libgcrypt20
• libnghttp2-14
• librtmp1
• libssh2-1
• libzstd1

I will raise a separate PR for 23.10 and 24.04, this is having too much overlap, I will raise a fresh, dont worry. I have this in my task list. Also wanted to know what do we have to do to add a certain package avaiable for certain release?

[cjdcordeiro]

Cool ;) I ack the extra work, but it is a policy we need to enforce to make sure the DB of slices grows consistently across releases (to avoid inconsistent slice names and definitions for the same package in different releases)

what do we have to do to add a certain package avaiable for certain release?

Do you mean, adding a package to the upstream Ubuntu archives? If so, this is a distro question. Assuming you're talking about libunistring2, the best is to create a bug report in https://bugs.launchpad.net/ubuntu/+source/libunistring/+filebug

[ghost]

@rebornplusplus @cjdcordeiro
1.I have fixed all the open question in this PR.
2. Raised PR for noble #133
This PR is good for review.

[cjdcordeiro]

Thanks @yashashwi !

This LGTM.
Thanks for #133 . We also need one for 23.10, excluding libpsl5 because of the
libunistring2 issue.

[ghost]

Thanks @yashashwi !

This LGTM.
Thanks for #133 . We also need one for 23.10, excluding libpsl5 because of the
libunistring2 issue.

@cjdcordeiro for 23.10, I have raised already its already in the list of open PR.

[rebornplusplus]

Looks good to me now, thank you!

[rebornplusplus]

Ya, I have updated the PR description with the list of forward-port PRs.

[cjdcordeiro]

Indeed, I missed it from the list of open PRs. all good!