feat: adding support for getChart #9
Conversation
matthew-hagemann
force-pushed
the
chart-endpoint
branch
from
be5f22a
to
caab17f
Compare
matthew-hagemann
force-pushed
the
chart-endpoint
branch
from
86e0f8a
to
01b55d2
Compare
|
Not letting me add non-Canonical members as reviewers, but here are the changes to the client for the upcoming chart endpoints @spydon @BLKKKBVSIK |
lib/app_center_ratings_client.dart
Outdated
| @@ -3,15 +3,18 @@ import 'dart:async'; | |||
| import 'package:grpc/grpc.dart'; | |||
| import 'package:meta/meta.dart'; | |||
|
|
|||
| import 'src/app.dart' as app; | |||
| import 'src/chart.dart' as chart; | |||
There was a problem hiding this comment.
Does this contain classes with name collisions with other imports? Otherwise I'd drop the as chart.
There was a problem hiding this comment.
It is defined in my code and in the generated code, thats why I gave a prefix to mine. If it makes it clearer, I could swap the prefix to the protobuf generated classes and prefix them with pb.?:
package:app_center_ratings_client/src/chart.dart
package:app_center_ratings_client/src/generated/ratings_features_chart.pb.dart
There was a problem hiding this comment.
Ah, that would probably be clearer indeed!
lib/src/common.dart
Outdated
|
|
||
| part 'app.freezed.dart'; | ||
| @immutable | ||
| class Rating { |
There was a problem hiding this comment.
Since there are only Rating related things in here I would name this file rating.dart or something like that, I usually try to avoid file names like common or utils, since they don't really say much about the content (and also allows for a wide mix of things within one file, which is usually discouraged).
Implementing getChart gRPC
Ratings service PR