feat: getChart #41
Merged
feat: getChart #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-hagemann
force-pushed
the
chart-protos
branch
2 times, most recently
from
7e9009b
to
ba6d86c
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
from
ba6d86c
to
9bdd1e5
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
from
88c2209
to
6440891
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
from
b311c5e
to
0bcab50
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
2 times, most recently
from
81cb188
to
dc8f5e7
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
from
2307068
to
b76bcaf
Compare
matthew-hagemann
force-pushed
the
chart-protos
branch
from
ba7038b
to
3952941
Compare
ZoopOTheGoop
reviewed
Dec 7, 2023
src/features/app/interface.rs
Outdated
| @@ -1,16 +1,11 @@ | |||
| use crate::app::AppContext; | |||
|
|
|||
| use self::protobuf::{App, GetRatingRequest, GetRatingResponse}; | |||
| pub use protobuf::app_server; | |||
| use crate::features::pb::app::{GetRatingRequest, GetRatingResponse}; | |||
There was a problem hiding this comment.
This also applies to Line 1 and later lines, but probably best to merge all the use crate::{...} into a single line so it's easier to find all imports.
src/features/app/interface.rs
Outdated
|
|
||
| tonic::include_proto!("ratings.features.app"); | ||
| } | ||
| use super::{service::AppService, use_cases}; |
There was a problem hiding this comment.
Any reason to not use crate:: here? I rarely see Rust crates use super except in unit tests, but I won't be too picky.
There was a problem hiding this comment.
No reason, totally agree with use crate:: 🙂
src/features/app/use_cases.rs
Outdated
| @@ -1,7 +1,7 @@ | |||
| use crate::app::AppContext; | |||
| use crate::{app::AppContext, features::common::entities::Rating}; | |||
There was a problem hiding this comment.
Maybe merge with the super block below (as per previous comment)
matthew-hagemann
force-pushed
the
chart-protos
branch
from
b84bae7
to
3cc3073
Compare
ZoopOTheGoop
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartDatato include the ratings_band and raw ratingfeatures/app&features/chartRatingandRatingsBandreusableVoteSummaryinstead of extracting a list of votes and processing in RustgetChartendpointCloses #35, #15
Client update