Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat responsibilities like other parameters #645

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Treat responsibilities like other parameters #645

wants to merge 13 commits into from

Conversation

MarcelGarus
Copy link
Member

Closes: #630

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jwbot jwbot enabled auto-merge August 12, 2023 14:09
@jwbot jwbot added P: Compiler: Language Server Package: The Candy Language Server P: Compiler: Frontend Package: The compiler frontend P: Compiler: Fuzzer Package: Candy's built-in fuzzer fuzzing Candy code P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Compiler: CLI Package: Candy's command-line interface labels Aug 12, 2023
@MarcelGarus MarcelGarus requested review from JonasWanke and ctiedt and removed request for JonasWanke August 12, 2023 14:10
@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: 87fecea..4d3c14b

@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: 87fecea..1421749

ctiedt
ctiedt requested changes Aug 12, 2023
View reviewed changes
compiler/cli/src/run.rs Outdated Show resolved Hide resolved
@jwbot jwbot added the P: Compiler: Inkwell Backend Package: Inkwell Compiler Backend producing native code via LLVM label Aug 12, 2023
@MarcelGarus MarcelGarus requested a review from ctiedt August 12, 2023 15:15
@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: 87fecea..e05974a

@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: 87fecea..1248f40

@jwbot
Copy link
Collaborator

jwbot commented Aug 12, 2023

The golden IRs have changed: 87fecea..e03298e

@jwbot
Copy link
Collaborator

jwbot commented Aug 17, 2023

The golden IRs have changed: 87fecea..2fb0c98

@jwbot
Copy link
Collaborator

jwbot commented Aug 17, 2023

The golden IRs have changed: 87fecea..266f8fd

@jwbot
Copy link
Collaborator

jwbot commented Aug 17, 2023

The golden IRs have changed: 87fecea..5b18e90

@JonasWanke JonasWanke added the T: Refactor Type: Refactoring label Aug 17, 2023
@MarcelGarus MarcelGarus mentioned this pull request Aug 17, 2023
Closed
2 tasks
@MarcelGarus MarcelGarus marked this pull request as draft January 25, 2024 16:26
auto-merge was automatically disabled January 25, 2024 16:26

Pull request was converted to draft

@MarcelGarus
Copy link
Member Author

Does this make sense? Within the MIR, this is totally fine, but at the borders to other IRs this becomes really messy and ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctiedt ctiedt Awaiting requested review from ctiedt

Requested changes must be addressed to merge this pull request.

Assignees

@MarcelGarus MarcelGarus

Labels
P: Compiler: CLI Package: Candy's command-line interface P: Compiler: Frontend Package: The compiler frontend P: Compiler: Fuzzer Package: Candy's built-in fuzzer fuzzing Candy code P: Compiler: Inkwell Backend Package: Inkwell Compiler Backend producing native code via LLVM P: Compiler: Language Server Package: The Candy Language Server P: Compiler: VM Package: The VM executing Candy byte code (LIR) T: Refactor Type: Refactoring
Projects
🍭 Candy
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIR: Move responsible parameter into normal parameters
4 participants
@MarcelGarus @jwbot @ctiedt @JonasWanke