Skip to content

Commit

Permalink
Fix benchmarks
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcelGarus committed Aug 12, 2023
1 parent 33703b3 commit 20ea4bc
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions compiler/vm/benches/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,14 @@ pub fn run(lir: impl Borrow<Lir>) -> (Heap, InlineObject) {
// Run the `main` function.
let environment = Struct::create(&mut heap, true, &FxHashMap::default());
let responsible = HirId::create(&mut heap, true, hir::Id::user());
let VmFinished { heap, result, .. } =
Vm::for_function(lir, heap, main, &[environment.into()], responsible, tracer)
.run_forever_without_handles();
let VmFinished { heap, result, .. } = Vm::for_function(
lir,
heap,
main,
&[environment.into(), responsible.into()],
tracer,
)
.run_forever_without_handles();
match result {
Ok(return_value) => (heap, return_value),
Err(panic) => {
Expand Down

2 comments on commit 20ea4bc

@jwbot
Copy link
Collaborator

@jwbot jwbot commented on 20ea4bc Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler

Benchmark suite Current: 20ea4bc Previous: 80cf82b Ratio
Time: Compiler/hello_world 21743891 ns/iter (± 364847) 15639753 ns/iter (± 251968) 1.39
Time: Compiler/fibonacci 181015423 ns/iter (± 1045168) 148265880 ns/iter (± 799334) 1.22
Time: VM Runtime/hello_world 16400 ns/iter (± 2236) 13150 ns/iter (± 1270) 1.25
Time: VM Runtime/fibonacci/15 514434933 ns/iter (± 1451508) 251217308 ns/iter (± 1167109) 2.05
Time: VM Runtime/PLB/binarytrees/6 2512740034 ns/iter (± 4478701) 1149632675 ns/iter (± 3822908) 2.19

This comment was automatically generated by workflow using github-action-benchmark.

@jwbot
Copy link
Collaborator

@jwbot jwbot commented on 20ea4bc Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compiler'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 20ea4bc Previous: 80cf82b Ratio
Time: VM Runtime/fibonacci/15 514434933 ns/iter (± 1451508) 251217308 ns/iter (± 1167109) 2.05
Time: VM Runtime/PLB/binarytrees/6 2512740034 ns/iter (± 4478701) 1149632675 ns/iter (± 3822908) 2.19

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.