Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not mark job worker user task as incorrect #4724

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Nov 25, 2024

Closes #4718

Proposed Changes

This removes the error as user tasks implemented as job workers are still allowed in Camunda 8.7.

image

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac barmac requested review from a team, philippfromme and jarekdanielak and removed request for a team November 25, 2024 10:42
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 25, 2024
CHANGELOG.md Outdated
@@ -45,6 +45,7 @@ ___Note:__ Yet to be released changes appear here._
* `FIX`: correct dangling selection after search pad interaction ([bpmn-io/diagram-js#947](https://github.com/bpmn-io/diagram-js/pull/947))
* `FIX`: create new user task form only if user task form referenced ([camunda/camunda-bpmn-js-behaviors#85](https://github.com/camunda/camunda-bpmn-js-behaviors/pull/85), [#4658](https://github.com/camunda/camunda-modeler/issues/4658))
* `FIX`: keep multi-instance characteristics on type change ([#4310](https://github.com/camunda/camunda-modeler/issues/4310))
* `FIX`: do not mark job worker user task as incorrect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `FIX`: do not mark job worker user task as incorrect
* `FIX`: do not mark job worker user task as incorrect ([camunda/bpmnlint-plugin-camunda-compat#182](https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/182))

@barmac barmac requested a review from philippfromme November 25, 2024 12:19
@barmac barmac merged commit 336b066 into main Nov 25, 2024
10 of 12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 25, 2024
@barmac barmac deleted the 4718-update-camunda-linting branch November 25, 2024 12:37
@github-actions github-actions bot added this to the M83 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants