Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated deprecation report for user task implemented as job worker #4718

Closed
barmac opened this issue Nov 22, 2024 · 6 comments
Closed

Duplicated deprecation report for user task implemented as job worker #4718

barmac opened this issue Nov 22, 2024 · 6 comments
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M83

Comments

@barmac
Copy link
Collaborator

barmac commented Nov 22, 2024

Describe the bug

A single user task with implementation "job worker" triggers two linting reports:

image

Steps to reproduce

  1. Create a user task
  2. Set execution platform to Camunda 8.7
  3. now this happens

Expected behavior

Single report, or even no report since there was a decision to postpone deprecation of job worker implementation.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.30.0-rc.0
  • Execution Platform: C 8.7
  • Installed plug-ins: [...]

Additional context

No response
@barmac barmac added the bug Something isn't working label Nov 22, 2024
@barmac barmac mentioned this issue Nov 22, 2024
Closed
38 tasks
@philippfromme
Copy link
Contributor

philippfromme commented Nov 22, 2024 •
edited
Loading

For some reason the second one is reported by the task-listener rule which doesn't seem to make any sense.

image

@philippfromme
Copy link
Contributor

The task-listener rule reports missing zeebe:UserTask extension elements. It's supposed to report an error only if there is a task listener without it being a Zeebe user task. It currently doesn't work like that. The respective test case is broken: camunda/bpmnlint-plugin-camunda-compat@5e72cc8#diff-d5248d13c56ad890a6422c34bdd0acbf09123180008ce3451a328afaf2c6b22fR31

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Thanks for the insight @philippfromme.

@barmac barmac self-assigned this Nov 22, 2024
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: do not mark job worker user task as incorrect
ce3f200 
Related to camunda/camunda-modeler#4718
@barmac barmac mentioned this issue Nov 22, 2024
Merged
@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

This will be fixed via camunda/bpmnlint-plugin-camunda-compat#182

@barmac barmac added the in progress Currently worked on label Nov 22, 2024
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: remove zeebe-user-task rule
8a47161 
The rule was added too early as the feature is still supported in
all versions of Camunda.

Related to camunda/camunda-modeler#4718
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: remove zeebe-user-task rule
773ee20 
The rule was added too early as the feature is still supported in
all versions of Camunda.

Related to camunda/camunda-modeler#4718
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: do not mark job worker user task as incorrect
56fb877 
Related to camunda/camunda-modeler#4718
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: remove zeebe-user-task rule
dde2f20 
The rule was added too early as the feature is still supported in
all versions of Camunda.

Related to camunda/camunda-modeler#4718
barmac added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Nov 22, 2024
@barmac
fix: do not mark job worker user task as incorrect
4307477 
Related to camunda/camunda-modeler#4718
@barmac barmac added the fixed upstream Requires integration of upstream change label Nov 22, 2024
@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2024

Fixed upstream in camunda/bpmnlint-plugin-camunda-compat#182, and pending linting release.

@barmac barmac removed the in progress Currently worked on label Nov 25, 2024
barmac added a commit that referenced this issue Nov 25, 2024
@barmac
fix: do not mark job worker user task as incorrect
8d97943 
Closes #4718
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Nov 25, 2024
@barmac barmac mentioned this issue Nov 25, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 25, 2024
barmac added a commit that referenced this issue Nov 25, 2024
@barmac
fix: do not mark job worker user task as incorrect
989fd89 
Closes #4718
@barmac
Copy link
Collaborator Author

barmac commented Nov 25, 2024

Closed via #4724

@barmac barmac closed this as completed Nov 25, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 25, 2024
@github-actions github-actions bot added this to the M83 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M83
Development

No branches or pull requests
2 participants
@philippfromme @barmac