Do not error for job worker user task #182
Conversation
|
CC @misiekhardcore as you implemented the task listener rule (potential learning) |
index.js
Outdated
| @@ -249,7 +248,7 @@ module.exports = { | |||
| } | |||
|
|
|||
| return type; | |||
| }, null) | |||
| }, null) || 'error' | |||
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
Otherwise, the all configuration contains null value for rules not present in the presets.
| @@ -96,7 +96,6 @@ const camundaCloud86Rules = withConfig({ | |||
|
|
|||
| const camundaCloud87Rules = withConfig({ | |||
| ...omit(camundaCloud86Rules, [ 'no-task-listeners' ]), | |||
| 'zeebe-user-task': 'error', | |||
There was a problem hiding this comment.
I would prefer to remove the rule and all related tests for now. We don't keep rules in the codebase that aren't used.
There was a problem hiding this comment.
I think a complete rule removal is a breaking change. I don't think it's necessary for the bugfix.
There was a problem hiding this comment.
I consider the rule being there a bug. We remove it, we fix the bug. 😆
rules/camunda-cloud/task-listener.js
Outdated
| const taskListeners = findExtensionElement(node, 'zeebe:TaskListeners'); | ||
|
|
||
| if (!taskListeners) { | ||
| return; | ||
| } | ||
|
|
||
| let errors = hasExtensionElement(node, 'zeebe:UserTask'); |
There was a problem hiding this comment.
This is still going to report the same error which only states that the extension element is required. It doesn't hint at the fact that this extension element is only required if another extension element is present. We have a similar error type for properties (cf. https://github.com/camunda/bpmnlint-plugin-camunda-compat/blob/main/rules/utils/error-types.js#L17). I'd consider adding a EXTENSION_ELEMENT_DEPENDENT_REQUIRED error type.
There was a problem hiding this comment.
I will use the error you suggested.
There was a problem hiding this comment.
Oh OK so there is no such error yet...
There was a problem hiding this comment.
We have just clarified that we will remove the check since you cannot model a job worker user task with task listeners in the UI.
This is to not lint a situation which can be achieved via manual XML modification. Related to #182 (comment)
|
Works for me. This is supporting future platforms, rules are "a floating target" for these. As long as we don't break API we can phrase things as minor. |
The rule was added too early as the feature is still supported in all versions of Camunda. Related to camunda/camunda-modeler#4718
This is to not lint a situation which can be achieved via manual XML modification. Related to #182 (comment)
barmac
force-pushed
the
remove-user-task-implementation-from-camunda-8-7
branch
from
8a47161 to
f6313a1
Compare
|
Good job! 👍🏻 |
Two parts:
Related to camunda/camunda-modeler#4690
Related to camunda/camunda-modeler#4718