-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camunda Exporter to Announcements page #4715
Conversation
👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hi @ChrisKujawa we already have a new draft Announcements PR in progress for alpha 2 #4679 - can I just pull this content out from your PR and add it into this existing PR please? |
As agreed with @ChrisKujawa, I'll review this PR then bring the approved content into the draft Announcements PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisKujawa I've reviewed and made amends directly to the text, I'm going to look at the images next, but looks good - I assume we are allowed/it is okay to expose our architecture to users like this?
In my opinion we should. I actually wanted to have anyway a better overview for our architecture. I would see this as first step |
@ChrisKujawa I've modified the Miro diagram for the harmonized schema - it's just a quick alignment on colours, accessibility (e.g. text on block colours is bad for accessibility), but will do until i can take a look at our diagramming standards across the board (it's on the wishlist). |
Love it ! Thank you 🙏🏼 |
@mesellings We need to update the image and miro board, we realized a flaw in the index naming. I will change the miro board, can you upload an new screenshot? |
@ChrisKujawa I've added the second diagram now as well - let me know when you have made your changes. Note: I've locked these two diagrams on the Miro board so we don't change accidentally - Miro can be a bit flaky sometimes). |
Thanks @mesellings for your efforts 👍🏼 |
@ChrisKujawa Are you happy for me to port the content over into the Announcements PR, or are you waiting for any other reviewer? |
I think we fine now @mesellings. I also got positive feedback from Amara so I think we are good. We anyway can always iterate 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving despite two somewhat nitpicky comments that can be handled on the overall announcements PR. Your choice :)
Since this discussion is on a private channel, this high-level overview is perfect for announcements, but we should come back and add links to other pages or a blog when more info is available.
|
||
- For example, Tasklist and Operate Importers are still required for old data to be imported, but the Camunda exporter writes all new data into ES/OS. After old indices are drained, importers can be turned off. | ||
|
||
- The Archiver, which takes care of the archiving of completed process instances, will be moved into the Zeebe system as well, to reduce the installation complexity and provide a better scaling and replication factor (based on partitions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "Archiver" really be capitalized?
|
||
![camunda-exporter-target](./img/target-camunda-exporter.png) | ||
|
||
- For example, Tasklist and Operate Importers are still required for old data to be imported, but the Camunda exporter writes all new data into ES/OS. After old indices are drained, importers can be turned off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one use of ES/OS in the docs today, but in line 32 can we adjust this to "ElasticSearch (ES) or Opensearch (OS)" so the rest of the announcement we can say ES/OS without creating potential confusion?
🧠 🤝 🧠 (even if I'm slower, by 2 min 😆) |
@ChrisKujawa I've taken the content from this PR now, so it can be closed - thanks for your help with this, great work 👍 🚀 |
Closed as this content was added into #4679 |
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).