-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(self-managed): add infrastructure diagrams for EKS #4714
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @leiicamundi! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These diagrams look great to me, and I like the inclusion of the full-size links. Happy to approve, but will defer to @mesellings if there are any suggestions on how to best direct a user to click the image.
docs/self-managed/setup/deploy/amazon/amazon-eks/dual-region.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lars Lange <[email protected]>
@leiicamundi As mentioned I can take a look at this after the release next week, but as part of the release announcements I edited the Miro diagrams in #4715, so you can see the type of work I was talking about, i.e. to get the Miro diagrams into shape for the docs. e.g. |
Hi @mesellings, |
Hi @leiicamundi I haven't been able to yet, but thanks for reminding me as this had slipped off my radar - as I'm release manager for the alpha 3 release, I might aim to take a look at these after that, but 8.7 sounds good. Have a great holiday season as well, we'll pick this up in the new year! 👍 |
Description
This PR introduces reference architecture diagrams following the effort referenced in https://github.com/camunda/team-infrastructure-experience/issues/498. This PR is currently focused on EKS only as ROSA will have a dedicated PR.
The diagrams are only applicable to 8.7 as we don't plan to backport it to previous versions.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).