chore (docusaurus 3): regenerate vNext API docs #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 🤖 🤔 Hello, @pepopowitz! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
We can either use that PR or close it and start fresh. Given my shift in priorities, it's very unlikely I'll be able to help with this work. My PR did give me something to point to when people asked "why can't we just update to Docusaurus 3?!" As our docs infra DRI, you can close it or continue to work with it, doesn't matter to me @pepopowitz. |
I'm still digging out of notifications, but do you have this work represented somewhere outside of this PR? |
I don't, right now it's in my head as things I wanted to follow up with this week. I will track them if I don't get to them very soon. |
|
@pepopowitz do you expect this PR to build? I added the deploy label just to make sure things looked good, but realized the build failed. |
|
I don't think it will build, at least not yet. Both the things I called out earlier would need to be resolved for this to build (if there aren't also build issues in the base branch). Don't worry about approving this for now, though. I think the whole d-rex 3 branch needs to be updated on main, and that makes this branch probably meaningless right now. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #4560. Feel free to merge it at your convenience @akeller; I decided I didn't want to just start dumping big commits into your PR, or wreck how you were tracking your progress.
Regenerates the API docs for vNext, for all APIs. This should help resolve markdown errors in that version.
Things this PR doesn't include, but I learned will also be necessary in the d3 conversion:
useDocfrom the base theme, which is no longer exposed to us.When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).