-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path to Docusaurus 3 #4560
Path to Docusaurus 3 #4560
Conversation
👋 🤖 🤔 Hello, @akeller! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
In the API spec
|
@@ -70,7 +70,7 @@ | |||
"jest": "^29.6.4", | |||
"lint-staged": "^14.0.1", | |||
"playwright": "^1.32.2", | |||
"prettier": "3.0.0", | |||
"prettier": "2.8.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, prettier went to the past...
The deploy tag produces a different issue, the version of Node is old. That's not what I get on my local machine, instead I experience this: Screen.Recording.2024-11-06.at.2.17.17.PM.mov |
I can't find this comment anywhere, but I swear I left it on one of these issues -- All of these errors in the API specs will be resolved when we can update the API generator & regenerate these docs. I've confirmed locally. I hope you don't mind, I'm going to regenerate them on this branch and push up, to try to move this forward. |
#4667 bumps node to the current lts version in the .nvmrc (for people who use version managers locally), and each of the workflows that specify a node version. This should hopefully help? |
This is interesting, I hadn't noticed that the preview environment workflow doesn't specify a node version. I'll update it to do so, and include it in #4667. |
Eeeehhhhh I decided I didn't want to throw a bunch of junk into your PR, so I opened my own, into this branch, at #4669. Two things I learned from that, which are necessary during the upgrade:
|
@pepopowitz I mentioned this on your PR, but the likelihood of me getting back to this work before the end of the year is zero at this point. You can repurpose this PR or close it out, but I won't be able to get to it. |
Ok! I hope to make progress on it before the end of this year, so I will take it over. I'll look at it this week and decide if I want to start over or update this PR based on main. |
* regen vnext/camunda-api-rest specs * regen vnext/camunda-sm-api specs * regen vnext/operate-api specs * regen vnext/tasklist-api-rest specs * regen vnext/zeebe-api-rest specs
Closing in favor of #4781, and I'll take this work over. |
Description
This is my mess. You can join me here, or tackle things piecemeal. Related to #2719.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).