Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(concepts): Add documentation for Execution Listeners #4017

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

ce-dmelnych
Copy link
Contributor

@ce-dmelnych ce-dmelnych commented Jul 4, 2024

Description

Relates to: camunda/camunda#16219

This PR adds documentation for Execution Listeners (EL) in Camunda 8, providing developers with a guide on how to implement and utilize ELs effectively in their workflows.

It includes the following sections:

  • Introduction: Overview, and use cases of ELs.
  • Getting Started: Steps to enable ELs in BPMN models.
  • Limitations: ELs limitations.
  • Usage: How to define Job Workers to process EL jobs.
  • Variables: Handling variables within ELs, including scope and dynamic variable handling.
  • References: Links to additional documentation.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

This commit introduces initial documentation for ELs in Camunda 8.

It includes the following sections:
- **Introduction**: Overview, benefits, and use cases of ELs.
- **Getting Started**: Steps to enable ELs in BPMN models.
- **Supported Elements**: A table of BPMN elements that support `start` and `end` ELs.
- **Parameters and Configuration**: Explanation of EL parameters and example configurations.
- **Limitations**: ELs limitations.
- **Usage**: How to define Job Workers to process EL jobs.
- **Variables**: Handling variables within ELs, including scope and dynamic variable handling.
- **Examples**: Some examples of EL usage.
- **Element Processing Flow**: A flowchart and detailed steps describing the lifecycle of elements with ELs.
- **FAQ**: Common questions and troubleshooting tips.
- **References**: Links to additional documentation.

The documentation aims to provide a guide for developers to effectively implement and utilize Execution Listeners in their workflows.
@ce-dmelnych ce-dmelnych self-assigned this Jul 4, 2024
@ce-dmelnych ce-dmelnych added the component:zeebe Issues related with Zeebe project label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/concepts/execution-listeners.md
  • docs/reference/glossary.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@ce-dmelnych ce-dmelnych added the 8.6.0-alpha4 August 2024 alpha release label Jul 4, 2024
This commit introduces initial documentation for ELs in Camunda 8.

It includes the following sections:
- **Introduction**: Overview, benefits, and use cases of ELs.
- **Getting Started**: Steps to enable ELs in BPMN models.
- **Supported Elements**: A table of BPMN elements that support `start` and `end` ELs.
- **Parameters and Configuration**: Explanation of EL parameters and example configurations.
- **Limitations**: ELs limitations.
- **Usage**: How to define Job Workers to process EL jobs.
- **Variables**: Handling variables within ELs, including scope and dynamic variable handling.
- **Examples**: Some examples of EL usage.
- **Element Processing Flow**: A flowchart and detailed steps describing the lifecycle of elements with ELs.
- **FAQ**: Common questions and troubleshooting tips.
- **References**: Links to additional documentation.

The documentation aims to provide a guide for developers to effectively implement and utilize Execution Listeners in their workflows.
…doc' into feature/add-execution-listeners-doc

# Conflicts:
#	docs/components/concepts/execution-listeners.md
@christinaausley
Copy link
Contributor

@ce-dmelnych Is this ready for review or not quite yet?

- adjust text for sections
- improve formatting
- add sections with limitations and workarounds
@ce-dmelnych ce-dmelnych marked this pull request as ready for review July 9, 2024 13:21
@ce-dmelnych
Copy link
Contributor Author

ce-dmelnych commented Jul 9, 2024

@ce-dmelnych Is this ready for review or not quite yet?

Hi @christinaausley ,

I have made some corrections, and the PR is now ready for review. However, it also requires an engineering review, so there might be some additional changes after that.

@saig0, could you please assist with the engineering review?

Here is the preview of 🆕 Execution Listeners page.
Thanks!

@ce-dmelnych ce-dmelnych linked an issue Jul 9, 2024 that may be closed by this pull request
@ce-dmelnych ce-dmelnych added the deploy Stand up a temporary docs site with this PR label Jul 9, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs July 9, 2024 13:44 Destroyed
Copy link
Contributor

github-actions bot commented Jul 9, 2024

The preview environment relating to the commit 8e7fc39 has successfully been deployed. You can access it on https://preview.docs.camunda.cloud/pr-4017/index.html.

@christinaausley
Copy link
Contributor

@ce-dmelnych Cool 👍 I'll have a look after @saig0.

@github-actions github-actions bot temporarily deployed to camunda-docs July 29, 2024 06:56 Destroyed
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ce-dmelnych thank you for writing the docs. It's a good start. 👍

However, I see the potential to make it more effective for users by rephrasing and restructuring some parts. I will schedule a meeting with you to discuss the improvements.

docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
docs/components/concepts/execution-listeners.md Outdated Show resolved Hide resolved
- restructure content
- remove not relevant parts
- change wording to focus on the user needs
@saig0
Copy link
Member

saig0 commented Aug 5, 2024

@ce-dmelnych I pushed the changes from our review meeting today. 🚀

christinaausley
christinaausley previously approved these changes Aug 5, 2024
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so clean and well documented! Great work 🚀

Should we also add this to the glossary?

- improve some wordings & formatting
- fix broken links
- add `Execution listener` term to glossary
@github-actions github-actions bot temporarily deployed to camunda-docs August 7, 2024 10:05 Destroyed
@ce-dmelnych
Copy link
Contributor Author

Thank you both for your valuable reviews and the improvements you committed to the documentation! 🙌

@saig0 , I appreciate the meeting and the suggestions you provided, which have greatly enhanced the clarity and effectiveness of the content 🙇‍♂️

@christinaausley, thank you for your positive feedback!
I’ve just pushed another commit with some small improvements to the wording and formatting, fixed a broken link, and added the Execution listener term to the glossary. Please review it to see if it aligns with your expectations.

Thanks again for your support and collaboration! 🚀

@megglos
Copy link
Contributor

megglos commented Aug 9, 2024

@saig0 @ce-dmelnych do you consider it doable to get this merged by Tuesday next week? Will include a link in the release blogpost then.

@saig0
Copy link
Member

saig0 commented Aug 9, 2024

@megglos yes. I'll review it on Monday.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@saig0 saig0 merged commit 9f270a7 into main Aug 12, 2024
9 checks passed
@saig0 saig0 deleted the feature/add-execution-listeners-doc branch August 12, 2024 09:03
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha4 August 2024 alpha release component:zeebe Issues related with Zeebe project deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Setup Execution Listener documentation
4 participants