Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zeebe:ExecutionListener #76

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Support zeebe:ExecutionListener #76

merged 2 commits into from
Jul 15, 2024

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Jul 5, 2024

This PR adds support for zeebe:ExecutionListener according to the support table in camunda/camunda-docs#4017

In the implementation, we don't care about element types which are not currently supported in Camunda, e.g.

  • adhoc subprocesses
  • transacations
  • complex gateway
  • conditional events

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 5, 2024
@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team July 5, 2024 09:27
Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just to clarify, we allow end listeners for all Escalation events, because we can not verify if the escalation will be interrupting from the element itself, correct?

cf. https://github.com/camunda/camunda-docs/pull/4017/files#diff-a74161458f7314ea1d7e09cd3e91e96f454af8faf451ca49793dd70ae39fbe9dR65

@barmac
Copy link
Contributor Author

barmac commented Jul 5, 2024

Looks good to me!

Just to clarify, we allow end listeners for all Escalation events, because we can not verify if the escalation will be interrupting from the element itself, correct?

cf. https://github.com/camunda/camunda-docs/pull/4017/files#diff-a74161458f7314ea1d7e09cd3e91e96f454af8faf451ca49793dd70ae39fbe9dR65

Correct. And IMO the order in which the events are configured should not affect the EL configuration.

I'd like to hold this PR until the discussion from https://camunda.slack.com/archives/GP70M0J6M/p1720185492298049 is resolved. Can you please have a look too? This PR implements (1) but I'm not so sure about this anymore.

@barmac
Copy link
Contributor Author

barmac commented Jul 15, 2024

We will enforce the event types, so this PR needs to be merged.

@barmac barmac merged commit 14cd88c into main Jul 15, 2024
5 checks passed
@barmac barmac deleted the execution-listeners branch July 15, 2024 12:57
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants