Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/modeler): document default-httl flag #3393

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 27, 2024

Description

Documents the newly added default-httl flag, contributed via camunda/camunda-modeler#4147 and camunda/camunda-modeler#4162.

Depends on #3387

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@nikku nikku requested a review from barmac February 27, 2024 22:55
@nikku nikku self-assigned this Feb 27, 2024
@nikku nikku added the component:desktop-modeler Issues related with Desktop Modeler label Feb 27, 2024
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.

  • docs/components/modeler/desktop-modeler/flags/flags.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

barmac
barmac previously approved these changes Feb 28, 2024
@nikku nikku force-pushed the document-httl-hint branch from 8329e1b to 2a40de9 Compare February 28, 2024 09:11
Base automatically changed from document-httl-hint to main February 28, 2024 09:29
@nikku nikku dismissed barmac’s stale review February 28, 2024 09:29

The base branch was changed.

@nikku nikku requested a review from barmac February 28, 2024 10:49
@nikku
Copy link
Member Author

nikku commented Feb 28, 2024

@barmac Please re-review. I had to update this PR and your review got dismissed 😭

@nikku nikku merged commit 49d113a into main Feb 28, 2024
9 checks passed
@nikku nikku deleted the nikku-patch-1 branch February 28, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:desktop-modeler Issues related with Desktop Modeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants