Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for HTTL mandatory for C7 #4062

Closed
16 tasks done
toco-cam opened this issue Jan 11, 2024 · 50 comments
Closed
16 tasks done

Improve UX for HTTL mandatory for C7 #4062

toco-cam opened this issue Jan 11, 2024 · 50 comments
Assignees
Labels
BPMN Camunda 7 Flags an issue as related to Camunda Automation Platform 7 enhancement New feature or request ux
Milestone

Comments

@toco-cam
Copy link
Member

toco-cam commented Jan 11, 2024

Problem you would like to solve

The current user experience around ensuring HTTL is set does not suit all user profiles. Users with a HTTL set as a Global Engine Flag are confused about the default values and the error warning.

Proposed solution

We use the following link to external documentation: https://docs.camunda.org/manual/latest/user-guide/process-engine/history/.

Alternatives considered

Yes

Additional context

No response

@nikku
Copy link
Member

nikku commented Jan 23, 2024

@toco-cam Thanks for opening this issue.

Let's get the documentation that is supposed to be linked in place. We can then go ahead to implement this fairly swiftly.

@toco-cam
Copy link
Member Author

@nikku can you share the link to the docs page again please.

@nikku
Copy link
Member

nikku commented Jan 23, 2024

We feature modeling guidance here.

@prajwolbhandari1
Copy link
Contributor

Let me work on it.

@prajwolbhandari1
Copy link
Contributor

prajwolbhandari1 commented Feb 1, 2024

@toco-cam @nikku

Did we decide on this solution?

On the proposed solution above:

  1. No default values are displayed in Modeler for HTTL (CMMN, DMN, BPMN)
    -- no default values.

  2. Modeler displays an info with the suggestion to set the HTTL to 180 days as a starting point, with a link to the linting hints (in the docs) which explains why HTTL is necessary and how to set an engine HTTL
    -- what exactly does it mean by 180 days as a starting point? Since you suggested no default values in Add a stripped down menu #1.
    -- docs hints this link -> https://docs.camunda.org/manual/7.20/update/minor/719-to-720/#enforce-history-time-to-live

  3. For Power Users (With engine configuration) the Modeler provides a flag to disable the info for users with HTTL configured on the engine)
    -- which flag are you referring to? Can u please elaborate on this?

Also, are we going to use flags.json file to set historyTimeToLive value in modeler or just leaving empty with a linting doc link as mentioned above.

Attached: I made historyTimeToLive textfield as an optional. I will add linting hints - a doc link.

httlNotRequired_modeler.mov

@prajwolbhandari1
Copy link
Contributor

@nikku @toco-cam Once we finalize with a solution. Can you please put my name on the ticket? I can work on this.

@prajwolbhandari1
Copy link
Contributor

Here is the updated history time to live lint that points to the doc on BMPM side. Please clarify on the above questions.

lint.link.to.link.doc.mov

@prajwolbhandari1
Copy link
Contributor

prajwolbhandari1 commented Feb 5, 2024

@toco-cam @nikku any thoughts?

@nikku
Copy link
Member

nikku commented Feb 5, 2024

@prajwolbhandari1 Thanks for your work on this. We'll only be able to pick this up starting from next week. If you want to you can already open a PR in the mean time.

Validation for HTTL being missing must be updated via bpmnlint-plugin-camunda-compat. Thanks!

@prajwolbhandari1
Copy link
Contributor

@nikku thank you for your reply.

We are able to get rid of the validation updating bpmnlint-plugin-camunda-compat (Opening a PR soon) but we have few questions on the proposed solution that I posted above. Do you mind looking at it (few posts above)?

@prajwolbhandari1
Copy link
Contributor

@nikku @toco-cam can you guys please help me understand the proposed solution? My question is above.

Also, are you sure we don't want #3869 as an option? It will help to set default value in modeler. I can see it will solve few use cases.

@nikku
Copy link
Member

nikku commented Feb 6, 2024

@prajwolbhandari1 Not sure which question you refer to. The only one I found was this one:

For Power Users (With engine configuration) the Modeler provides a flag to disable the info for users with HTTL configured on the engine)

-- which flag are you referring to? Can u please elaborate on this?

We are going to introduce a flag, controlled via flags.json or command line to opt-out of the HTTL hint. I propose the name of the flag shall be disable-httl-hint. We'll not provide a default value via that flag, as either the user shall explicitly set the HTTL or the engine mandates the HTTL to be used.

@prajwolbhandari1
Copy link
Contributor

prajwolbhandari1 commented Feb 6, 2024

@nikku appreciate it!

Does it make sense to put user hint as 'Set Time to Live as 180. <Link for docs>' ?
<Link for docs> -> https://docs.camunda.org/manual/7.20/update/minor/719-to-720/#enforce-history-time-to-live

@prajwolbhandari1
Copy link
Contributor

I am working on with the team to raise a PR that we worked on so far. Raising the PR soon tomorrow or day after.

@nikku
Copy link
Member

nikku commented Feb 8, 2024

@toco-cam We could consider to address this along with #4120.

@prajwolbhandari1
Copy link
Contributor

prajwolbhandari1 commented Feb 8, 2024

@nikku @toco-cam I also see the similar message in cmmn deployments if I try to deploy a CMMN Diagram without filling "History cleanup".

@toco-cam
Copy link
Member Author

toco-cam commented Feb 12, 2024

@prajwolbhandari1 Thanks for your support!

No default values are displayed in Modeler for HTTL (CMMN, DMN, BPMN)
The target is to handle all HTTL models similarly.

The idea was not to add a link directly to the toolbar - but instead add a "Model guideline" to https://docs.camunda.io/docs/next/components/modeler/reference/modeling-guidance/ and add a link into the linking text.

@nikku
Copy link
Member

nikku commented Feb 15, 2024

We have an initial draft for the modeling guidance: camunda/camunda-docs#3324.

@nikku
Copy link
Member

nikku commented Feb 15, 2024

As a start we want to tackle BPMN. Later DMN and (unlikely but possible) CMMN would follow suite.

@nikku nikku added BPMN and removed needs more information Requires additional information to be actionable. labels Feb 15, 2024
nikku added a commit that referenced this issue Feb 26, 2024
deps: update to [email protected]

feat(platform): add HTTL hint

  Related to #4062
nikku pushed a commit to camunda/camunda-docs that referenced this issue Feb 26, 2024
@nikku
Copy link
Member

nikku commented Feb 26, 2024

Documentation update is ready for review: camunda/camunda-docs#3324

@nikku
Copy link
Member

nikku commented Feb 26, 2024

Final batch of documentation updates incoming 🎉.

@prajwolbhandari1
Copy link
Contributor

@prajwolbhandari1 Thanks again. You PRs helped a ton to drive this forward.

We're still in the process of clarifying two things:

Only then we'll be able to move forward.

@nikku @toco-cam what did we decide on this, are we going ahead and merge it? This will help us in our use case. #4147

@nikku
Copy link
Member

nikku commented Feb 26, 2024

@prajwolbhandari1 Why do you favor diagram configuration over engine configuration?

If you want to go ahead with this, then please updated it on top of the latest develop branch (were we added the disable-httl-hint flag). Your PR could be a cherry on top if we see that it could be valueable for a use case.

@prajwolbhandari1
Copy link
Contributor

@nikku will do that and let you know.

@nikku
Copy link
Member

nikku commented Feb 26, 2024

@prajwolbhandari1 Why do you favor diagram configuration over engine configuration?

Please also allow us to learn about why you think this is a better approach, in your environment. This helps us evaluate how we further proceed.

@HarishMalavade
Copy link

@nikku in our organization our camunda set up is shared process engine and we have multiple product lines that have different requirements based on process they build. and each product line can have hundreds of process model include parent and call activities.
For Example our trade processes have requirement to retain history only for 30 days
Where as our Defined contribution processes have requirements to retain history for 180 days and some others beyond 80 days
Since all these processes are deployed to same engine(shared) and we cannot leverage one httl value on the engine side and at the same time we cannot have history retained forever for performance concerns.

We do give different version of desktop modelers to BPM developers across product lines with our custom elements template and settings like disabling cmmn, httl etc in a package that we give them.

the changes @prajwolbhandari1 made will allow us to enforce httl on the modeler side during design time (Catch on left)
We work for Fintech. Please request you if it does not impact anything else to merge code from @prajwolbhandari1 so we can benefit from this contribution.

nikku pushed a commit to camunda/camunda-docs that referenced this issue Feb 27, 2024
@prajwolbhandari1
Copy link
Contributor

@nikku just pushed the change #4147

nikku pushed a commit that referenced this issue Feb 27, 2024
…lag (#4147)

By specifying the flag `default-history-ttl` you can control which history time to live new Camunda 7 diagrams get created with.


Closes #3869
Related to #4062

Signed-off-by: Bhandari, Prajwol <[email protected]>
nikku added a commit that referenced this issue Feb 27, 2024
@nikku
Copy link
Member

nikku commented Feb 27, 2024

default-httl flag is going to be available to customized the default history time to live value to be used for new diagrams.

nikku added a commit that referenced this issue Feb 28, 2024
nikku added a commit to camunda/camunda-docs that referenced this issue Feb 28, 2024
* feat(components/modeler): add history-time-to-live guidance.

Related to camunda/camunda-modeler#4062

Co-authored-by: Nico Rehwaldt <[email protected]>
Co-authored-by: Maciej Barelkowski <[email protected]>
nikku added a commit to camunda/camunda-docs that referenced this issue Feb 28, 2024
nikku added a commit to camunda/camunda-docs that referenced this issue Feb 28, 2024
nikku added a commit to camunda/camunda-docs that referenced this issue Feb 28, 2024
@nikku
Copy link
Member

nikku commented Feb 28, 2024

Thanks @prajwolbhandari1, @HarishMalavade and anyone else who contributed to this discussion issue in a meaningful way ❤️.

This is scheduled for release with the next Desktop Modeler. I'm super happy how this turned out.

@nikku nikku closed this as completed Feb 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Feb 28, 2024
@prajwolbhandari1
Copy link
Contributor

Thanks @nikku for all your help.

theburi pushed a commit to camunda/camunda-docs that referenced this issue Jun 5, 2024
* feat(components/modeler): add history-time-to-live guidance.

Related to camunda/camunda-modeler#4062

Co-authored-by: Nico Rehwaldt <[email protected]>
Co-authored-by: Maciej Barelkowski <[email protected]>
theburi pushed a commit to camunda/camunda-docs that referenced this issue Jun 5, 2024
theburi pushed a commit to camunda/camunda-docs that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN Camunda 7 Flags an issue as related to Camunda Automation Platform 7 enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

4 participants