Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 8.3: reviewable steps #2718

Merged
merged 8 commits into from
Oct 9, 2023
4 changes: 4 additions & 0 deletions src/mdx/expandVersionedUrl.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
/** @type {Array<VersionMapping>} */
const versionMappings = [
// 👋 When cutting a new version, add a new mapping here!
{
docsVersion: "8.3",
optimizeVersion: "3.11.0",
},
Comment on lines +22 to +25
Copy link
Collaborator Author

@pepopowitz pepopowitz Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I forgot this, and it caused a bunch of broken links in the build

For future reference, if the build says this:

- On source page path = /optimize/self-managed/optimize-deployment/version-policy/:
   -> linking to $docs$/reference/release-policy/ (resolved as: /optimize/self-managed/optimize-deployment/version-policy/$docs$/reference/release-policy/)

...it means the version it's building isn't defined in this array, so it doesn't know what to resolve $docs$ or $optimize$ to. (Note the $docs$ in the broken link)

{
docsVersion: "8.2",
optimizeVersion: "3.10.0",
Expand Down