-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 8.3: reviewable steps #2718
Conversation
"3.10.0": { | ||
banner: "none", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents docusaurus from showing an "version is unsupported" banner, because we support previous versions for 18 months.
"3.11.0": { | ||
label: "8.3 / 3.11.0", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label has most recently been discussed in Slack.
Note that this label only applies to Optimize documentation.
This is what it looks like when viewing an Optimize page:
// surprising, yes, but true: 3.8 should show unsupported banner, but 3.7 should not. | ||
"3.7.0": { | ||
banner: "none", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.7.0 remains supported, as discussed in Slack.
banner: "none", | ||
}, | ||
"8.0": { | ||
8.1: { | ||
banner: "none", | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions just rotate. 8.0 becomes unsupported, 8.2 is configured to not show the "unsupported" banner.
"/docs/8.2/**", | ||
"/optimize/3.7.0/**", | ||
"/optimize/3.8.0/**", | ||
"/optimize/3.9.0/**", | ||
"/optimize/3.10.0/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only want the most recent docs in our sitemap.
NEW_DOCS_VERSION="8.3" | ||
PREVIOUS_DOCS_VERSION="8.2" | ||
NEW_OPTIMIZE_VERSION="3.11.0" | ||
PREVIOUS_OPTIMIZE_VERSION="3.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions are only used for the tooling that cuts a version, but it's nice to commit them so that it's easier to figure out how it works at time of next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Older version sidebars went from using versionless URLs to specifying their version.
# 8.2 content moves: These were removed from latest version docs, so point them back to previous version for now. | ||
# Remove them in the not-distant future. | ||
RewriteRule ^docs/guides/update-guide/026-to-100/?$ /docs/8.2/guides/update-guide/026-to-100/ [R=301,L] | ||
RewriteRule ^docs/guides/update-guide/100-to-110/?$ /docs/8.2/guides/update-guide/100-to-110/ [R=301,L] | ||
RewriteRule ^docs/guides/update-guide/110-to-120/?$ /docs/8.2/guides/update-guide/110-to-120/ [R=301,L] | ||
RewriteRule ^docs/guides/update-guide/120-to-130/?$ /docs/8.2/guides/update-guide/120-to-130/ [R=301,L] | ||
|
||
# 8.3 content moves | ||
RewriteRule ^docs/guides/update-guide/connectors/(.*)$ /docs/components/connectors/custom-built-connectors/update-guide/$1 [R=301,L] | ||
RewriteRule ^docs/guides/update-guide/(.*)$ /docs/self-managed/operational-guides/update-guide/$1 [R=301,L] | ||
RewriteRule ^docs/self-managed/backup-restore/(.*)$ /docs/self-managed/operational-guides/backup-restore/$1 [R=301,L] | ||
RewriteRule ^docs/self-managed/troubleshooting/log-levels/(.*)$ /docs/self-managed/operational-guides/troubleshooting/log-levels$1 [R=301,L] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been advocating for us to not maintain rewrite rules for "next" docs lately, but here I see the down-side -- I had to identify all these pages that moved in the next version, and add redirects for them.
I don't think this is wrong or a reason for us to maintain redirect rules for next docs...it is just noteworthy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WAHOOOOOO! Ship it 🚢
{ | ||
docsVersion: "8.3", | ||
optimizeVersion: "3.11.0", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! I forgot this, and it caused a bunch of broken links in the build
For future reference, if the build says this:
- On source page path = /optimize/self-managed/optimize-deployment/version-policy/:
-> linking to $docs$/reference/release-policy/ (resolved as: /optimize/self-managed/optimize-deployment/version-policy/$docs$/reference/release-policy/)
...it means the version it's building isn't defined in this array, so it doesn't know what to resolve $docs$
or $optimize$
to. (Note the $docs$
in the broken link)
* version: new versions of docs * version 8.3: reviewable steps (#2718) * chore: update cutNewVersions with new version numbers * version: sidebars * version: version manifests * version: redirects * chore: show/hide correct version banners, and customize the label for Optimize 3.11 * chore: redirects for content that moved between 8.2 and 8.3 * oops: swap the version numbers for 8.3 label * fix: map new versions to each other so cross-instance shortcuts can be resolved
Description
Part of #2432. Blocks #2717.
This PR includes the smaller changes for cutting versions 8.3/3.11.0, so that they can be reviewed by a human.
Once this is merged into its target branch, #2717 can be reviewed & merged!
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.