Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 8.3: reviewable steps #2718

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Oct 9, 2023

Description

Part of #2432. Blocks #2717.

This PR includes the smaller changes for cutting versions 8.3/3.11.0, so that they can be reviewed by a human.

Once this is merged into its target branch, #2717 can be reviewed & merged!

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz self-assigned this Oct 9, 2023
Comment on lines +53 to +55
"3.10.0": {
banner: "none",
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents docusaurus from showing an "version is unsupported" banner, because we support previous versions for 18 months.

Comment on lines +50 to +52
"3.11.0": {
label: "8.3 / 3.11.0",
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label has most recently been discussed in Slack.

Note that this label only applies to Optimize documentation.

This is what it looks like when viewing an Optimize page:

image

Comment on lines +59 to 62
// surprising, yes, but true: 3.8 should show unsupported banner, but 3.7 should not.
"3.7.0": {
banner: "none",
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7.0 remains supported, as discussed in Slack.

banner: "none",
},
"8.0": {
8.1: {
banner: "none",
},
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions just rotate. 8.0 becomes unsupported, 8.2 is configured to not show the "unsupported" banner.

Comment on lines +271 to +275
"/docs/8.2/**",
"/optimize/3.7.0/**",
"/optimize/3.8.0/**",
"/optimize/3.9.0/**",
"/optimize/3.10.0/**",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want the most recent docs in our sitemap.

Comment on lines +5 to +8
NEW_DOCS_VERSION="8.3"
PREVIOUS_DOCS_VERSION="8.2"
NEW_OPTIMIZE_VERSION="3.11.0"
PREVIOUS_OPTIMIZE_VERSION="3.10.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are only used for the tooling that cuts a version, but it's nice to commit them so that it's easier to figure out how it works at time of next release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older version sidebars went from using versionless URLs to specifying their version.

Comment on lines +13 to +24
# 8.2 content moves: These were removed from latest version docs, so point them back to previous version for now.
# Remove them in the not-distant future.
RewriteRule ^docs/guides/update-guide/026-to-100/?$ /docs/8.2/guides/update-guide/026-to-100/ [R=301,L]
RewriteRule ^docs/guides/update-guide/100-to-110/?$ /docs/8.2/guides/update-guide/100-to-110/ [R=301,L]
RewriteRule ^docs/guides/update-guide/110-to-120/?$ /docs/8.2/guides/update-guide/110-to-120/ [R=301,L]
RewriteRule ^docs/guides/update-guide/120-to-130/?$ /docs/8.2/guides/update-guide/120-to-130/ [R=301,L]

# 8.3 content moves
RewriteRule ^docs/guides/update-guide/connectors/(.*)$ /docs/components/connectors/custom-built-connectors/update-guide/$1 [R=301,L]
RewriteRule ^docs/guides/update-guide/(.*)$ /docs/self-managed/operational-guides/update-guide/$1 [R=301,L]
RewriteRule ^docs/self-managed/backup-restore/(.*)$ /docs/self-managed/operational-guides/backup-restore/$1 [R=301,L]
RewriteRule ^docs/self-managed/troubleshooting/log-levels/(.*)$ /docs/self-managed/operational-guides/troubleshooting/log-levels$1 [R=301,L]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been advocating for us to not maintain rewrite rules for "next" docs lately, but here I see the down-side -- I had to identify all these pages that moved in the next version, and add redirects for them.

I don't think this is wrong or a reason for us to maintain redirect rules for next docs...it is just noteworthy.

@pepopowitz pepopowitz added kind/feature Issues related with features to be documented dx Documentation infrastructure typically handled by the Camunda DX team labels Oct 9, 2023
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAHOOOOOO! Ship it 🚢

Comment on lines +22 to +25
{
docsVersion: "8.3",
optimizeVersion: "3.11.0",
},
Copy link
Collaborator Author

@pepopowitz pepopowitz Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! I forgot this, and it caused a bunch of broken links in the build

For future reference, if the build says this:

- On source page path = /optimize/self-managed/optimize-deployment/version-policy/:
   -> linking to $docs$/reference/release-policy/ (resolved as: /optimize/self-managed/optimize-deployment/version-policy/$docs$/reference/release-policy/)

...it means the version it's building isn't defined in this array, so it doesn't know what to resolve $docs$ or $optimize$ to. (Note the $docs$ in the broken link)

@pepopowitz pepopowitz merged commit 9c036e9 into pepopowitz/cut-8-3 Oct 9, 2023
4 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/cut-8-3-reviewable branch October 9, 2023 20:24
pepopowitz added a commit that referenced this pull request Oct 9, 2023
* version: new versions of docs

* version 8.3: reviewable steps (#2718)

* chore: update cutNewVersions with new version numbers

* version: sidebars

* version: version manifests

* version: redirects

* chore: show/hide correct version banners, and customize the label for Optimize 3.11

* chore: redirects for content that moved between 8.2 and 8.3

* oops: swap the version numbers for 8.3 label

* fix: map new versions to each other so cross-instance shortcuts can be resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/feature Issues related with features to be documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants