-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global booking limits for teams #16614
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that I can save 3 per day and 1 per year but on the event types limits it'll throw an error if I try that. Let's catch that edge case and then we can approve.
fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback addressed. Great work @CarinaWolli!
What does this PR do?
Adds a new feature for global booking limits for teams. Team global booking limits determine how many time team members can be booked from team event types (collective, round-robin)
Also fixes an existing bug with booking limits when host and attendees were in different timezones. Slots didn't load correctly and when trying to confirm the booking it was throwing
Could not book the meeting. Booking Limit for this event type has been reached
Also fixes issues with booking limits (duration and frequency) when event is rescheduled. It sometimes caused slots not to show up or for duration limits slots were correctly shown but it was throwing
Could not reschedule the meeting. Duration Limit for this event type has been reached
after confirming the bookingsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
settings/team/[id]/bookingLimits