Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: settings/teams and settings/billing - remove pages router and use app router #16751

Merged
merged 24 commits into from
Dec 4, 2024
Merged

chore: settings/teams and settings/billing - remove pages router and use app router #16751

merged 24 commits into from
Dec 4, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 21, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4383
  • remove pages router and use app router for all pages in settings/teams
  • remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • all settings/teams/**/* pages must work as expected

@graphite-app graphite-app bot requested review from a team September 21, 2024 00:01
@hbjORbj hbjORbj changed the title chore: settings/teams remove pages router and use app router chore: settings/teams - remove pages router and use app router Sep 21, 2024
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 21, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 21, 2024
@dosubot dosubot bot added teams area: teams, round robin, collective, managed event-types 💻 refactor labels Sep 21, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@linear Linear
Copy link

linear bot commented Sep 21, 2024

CAL-4383 `settings/teams` - Use app router and remove pages router

@hbjORbj hbjORbj added the high-risk Requires approval by Foundation team label Sep 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 21, 2024 •
edited
Loading

E2E results are ready!

sean-brydon
sean-brydon previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets add yarn.lock back in from main

yarn.lock Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we restore this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure, done!

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 4:09pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 4:09pm

@hbjORbj hbjORbj requested a review from sean-brydon September 23, 2024 13:55
@hbjORbj hbjORbj enabled auto-merge (squash) September 23, 2024 15:29
@hbjORbj hbjORbj disabled auto-merge September 23, 2024 17:38
@hbjORbj
Copy link
Contributor Author

hbjORbj commented Sep 23, 2024

TODO: Test on Prod

@hbjORbj
Copy link
Contributor Author

hbjORbj commented Sep 23, 2024

Added booking liimits page as a follow up of #16614

@hbjORbj
Copy link
Contributor Author

hbjORbj commented Dec 2, 2024

Blocked by the failing integration test. Seems like there's a problem with the test.

@hbjORbj hbjORbj marked this pull request as ready for review December 2, 2024 18:33
joeauyeung
joeauyeung previously approved these changes Dec 2, 2024
View reviewed changes
@hbjORbj hbjORbj mentioned this pull request Dec 4, 2024
Closed
3 tasks
@hbjORbj hbjORbj changed the title chore: settings/teams - remove pages router and use app router chore: settings/teams and settings/billing - remove pages router and use app router Dec 4, 2024
@hbjORbj hbjORbj enabled auto-merge (squash) December 4, 2024 16:34
@hbjORbj hbjORbj merged commit d60b6c6 into main Dec 4, 2024
38 checks passed
@hbjORbj hbjORbj deleted the chore/remove-pages-router-settings-teams branch December 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeauyeung joeauyeung joeauyeung approved these changes

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables high-risk Requires approval by Foundation team ready-for-e2e 💻 refactor teams area: teams, round robin, collective, managed event-types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hbjORbj @sean-brydon @joeauyeung @keithwillcode