Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Final Content into the Claim Tracker Application #348

Merged
merged 7 commits into from
Jul 30, 2021

Conversation

rocketnova
Copy link
Contributor

Ticket

Resolves #329

Changes

  • Update final English content
  • Update Spanish content
  • Add new program & extension types
  • Support unexpected program types

Context

  • Final English strings are in the application
    • Common strings
    • scenario specific strings
  • Translated strings are in the application

I split out a couple issues from this one:

  1. Add final missing translation strings #346
  2. Add fallback content for Scenario 2 if no interview time can be shown #347

Testing

Follow the testing instructions in #345 and check each scenario (English & Spanish) and each program type (English & Spanish).

@@ -36,7 +34,7 @@
},
"timeout-modal": {
"header": "Your Session Will End Soon",
"warning": "To protect your information, you will be logged out in {{count}} minute if you do not continue",
"warning": "To protect your information, you will be logged out in {{count}} minute if you do not continue.",
Copy link
Contributor

@nicoleslaw nicoleslaw Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be minutes, or are there times when it would be 1 minute?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just go with plural minutes here since it's only singular for... one minute

Copy link
Contributor

@lomky lomky Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to use i18n pluralization but it was giving me trouble. It might be worth another quick try though since Rocket solved a few bugs in my i18n setup!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, there is the plural down below on the next line! it properly pluralizes:

image

image

Copy link
Contributor

@kalvinwang kalvinwang Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, didn't realize we pluralized, thanks for checking Kat! Nicole check out the line below this one, warning_plural, to see what's used when {{count}} is greater than 1.

Copy link
Contributor

@lomky lomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I defer to @nicoleslaw for final okay on the content itself, but all the tech seems to work right with the new strings

Copy link
Contributor

@kalvinwang kalvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@nicoleslaw nicoleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any other changes for this but am assuming some of this will be updated via #346

Base automatically changed from rocket/341-scenario-2-summary to main July 30, 2021 17:33
@rocketnova rocketnova merged commit fdc36e7 into main Jul 30, 2021
@rocketnova rocketnova deleted the rocket/329-content-strings branch July 30, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Final Content into the Claim Tracker Application
4 participants