-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Final Content into the Claim Tracker Application #348
Conversation
@@ -36,7 +34,7 @@ | |||
}, | |||
"timeout-modal": { | |||
"header": "Your Session Will End Soon", | |||
"warning": "To protect your information, you will be logged out in {{count}} minute if you do not continue", | |||
"warning": "To protect your information, you will be logged out in {{count}} minute if you do not continue.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be minutes
, or are there times when it would be 1 minute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just go with plural minutes here since it's only singular for... one minute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to use i18n pluralization but it was giving me trouble. It might be worth another quick try though since Rocket solved a few bugs in my i18n setup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, didn't realize we pluralized, thanks for checking Kat! Nicole check out the line below this one, warning_plural, to see what's used when {{count}} is greater than 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I defer to @nicoleslaw for final okay on the content itself, but all the tech seems to work right with the new strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any other changes for this but am assuming some of this will be updated via #346
Ticket
Resolves #329
Changes
Context
I split out a couple issues from this one:
Testing
Follow the testing instructions in #345 and check each scenario (English & Spanish) and each program type (English & Spanish).