Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing <loc>https://www.bytebase.com</loc> in the generated sitemap #193

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

gustaveWPM
Copy link
Contributor

@gustaveWPM gustaveWPM commented Sep 28, 2023

I think that the transform function in the next-sitemap.config.js file is a little bit too aggressive.

Could you check it out?

CTRL+F https://www.bytebase.com<
https://www.bytebase.com/sitemap-0.xml

Fix proposal: 46ea2e9
Related issue: #192

@vercel
Copy link

vercel bot commented Sep 28, 2023

@gustaveWPM is attempting to deploy a commit to the bytebase Team on Vercel.

A member of the Team first needs to authorize it.

@gustaveWPM
Copy link
Contributor Author

Sorry, as I'm a complete beginner, I've made a lot of mistakes and I've had to edit my PR commit and my messages too many times.

It's OK now. 'night!

@gustaveWPM gustaveWPM changed the title fix: Missing <loc>bytebase.com</loc> in the generated sitemap fix: Maybe missing <loc>bytebase.com</loc> in the generated sitemap Sep 28, 2023
@gustaveWPM gustaveWPM changed the title fix: Maybe missing <loc>bytebase.com</loc> in the generated sitemap fix: Maybe missing <loc>https://bytebase.com</loc> in the generated sitemap Sep 28, 2023
@gustaveWPM gustaveWPM changed the title fix: Maybe missing <loc>https://bytebase.com</loc> in the generated sitemap fix: Missing <loc>https://www.bytebase.com</loc> in the generated sitemap Sep 28, 2023
@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bytebase-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 5:25am

Copy link
Member

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@gustaveWPM
Copy link
Contributor Author

gustaveWPM commented Sep 29, 2023

ping @tianzhou

Well... I still don't see the <loc>https://www.bytebase.com</loc> in the generated sitemap. :/
https://www.bytebase.com/sitemap-0.xml

On my side project, I had the same issue and fixed it like that.
But it doesn't seem to be enough in this case.

As I couldn't build the project (bytebase.com) locally on my machine, I didn't test a new generation of the sitemap.
I just made sure it works on my own project, and forwarded the fix.

It's embarrassing.
Maybe a Next Sitemap bug.
Based on my understanding, it appears that this can happen depending on the page's rendering strategy (Server/Static/SSG).

This is quite tedious because Next Sitemap behaves rather strangely.

I assume it's not a high priority at the moment.
I'll let you investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants