[Next Sitemap Config] Missing <loc>https://www.bytebase.com</loc> in the generated sitemap

[gustaveWPM]

Hello.

I noticed that <loc>https://www.bytebase.com</loc> is missing in the generated sitemap.

CTRL+F https://www.bytebase.com<
https://www.bytebase.com/sitemap-0.xml

---

In this PR:
#190

And more specifically, in this commit:
28fa929

You should beware of your custom transformation.

transform: async (config, path) => {
  if (path.startsWith('/en')) {
      path = path.substring(3);
  }
}

If your homepage is served at https://www.bytebase.com/en, then rewritten https://www.bytebase.com, you're currently losing it in your generated Sitemap with this transformation. (Because '/en'.substring(3) is equal to ''.)

Here is a proposal of fix:

⚠️ WRONG APPROACH: See #192 (comment)

// next-sitemap.config.js

// * ...
const DEFAULT_LANGUAGE = 'en';

// * ...
transform: (config, path) => {
  const DEFAULT_LANGUAGE_NEEDLE = '/' + DEFAULT_LANGUAGE;
  if (path.startsWith(DEFAULT_LANGUAGE_NEEDLE)) {
    if (path.length === DEFAULT_LANGUAGE_NEEDLE.length) path = '/'; // * ... RIGHT there! :D
    else path = path.substring(DEFAULT_LANGUAGE_NEEDLE.length);
  }
  // * ...
}

---

Also, I think we can get rid off the async function expression since the await operator isn't used yet in the transform function.
⬆️ (Still valid suggestion, unlike the code snippet just above.)

Cheers!

[gustaveWPM]

(Ongoing PR...)

[gustaveWPM]

Hmmm, actually, I think I've messed up my fix proposal.

Here is a new one:

// next-sitemap.config.js

// * ...
const DEFAULT_LANGUAGE = 'en';

// * ...
transform: (config, path) => {
  const defaultLanguageNeedle = '/' + DEFAULT_LANGUAGE;
  const defaultLanguageEnvelopeNeedle = defaultLanguageNeedle + '/';
  const defaultLanguageNeedleLen = defaultLanguageNeedle.length;
  if (path.startsWith(defaultLanguageEnvelopeNeedle)) {
    path = path.substring(defaultLanguageNeedleLen);
  } else if (path === defaultLanguageNeedle) {
    path = '/';
  }
  // * ...
}

ℹ️ I think we can get rid off the async function expression since the await operator isn't used yet in the transform function.

I think also that it is safer to check whether the path starts with /en/ or is just /en, and adjust the transformation as accurately as possible (so that /en/* becomes /*, and just /en becomes /).

[gustaveWPM]

Sorry, as I'm a complete beginner, I've made a lot of mistakes and I've had to edit my PR commit and my messages too many times.

It's OK now. 'night!

[gustaveWPM]

#193 (review)