Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sitemap generator #190

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

boojack
Copy link
Contributor

@boojack boojack commented Sep 28, 2023

This PR fixes no links in the generated sitemap.

image

Maybe related issue of next-sitemap:

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bytebase-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 11:16am

@tianzhou
Copy link
Member

Let's hold off then. Adding the /en may mess up our existing traffic ranking

@boojack
Copy link
Contributor Author

boojack commented Sep 28, 2023

Let's hold off then. Adding the /en may mess up our existing traffic ranking

Fixed in 28fa929

Copy link
Member

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianzhou tianzhou merged commit 4baf08d into main Sep 28, 2023
1 check passed
@tianzhou tianzhou deleted the steven/dvm-599-bytebasecom-sitemap-is-broken branch October 11, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants