-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the log library from fimber to logging #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good and tested
works with logcat and vscode dev console and easy to filter.
exporting the logs also works.
|
43f8ca8
to
1b763ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please re-trigger CI after breez-sdk changes are in place before merging, ty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One think I am missing is the sdk logs.
Now that the sdk logs exposes breezLogStream
shouldn't we use it here and log the records?
Yes; I'm doing it here: |
b4336d9
to
b170533
Compare
Reasons to change from Fimber to Logging:
Drawbacks
SizeRollingFileTree
How to test
Please also review the SDK side of the changes
breez/breez-sdk-greenlight#505
Fixes #588
Fixes #587