Remove log library from sdk and move logs for the app #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps not use any logging library in the sdk? We have API for listening to log messages where the user can listen to and has the freedom to choose her ownogging library on the application side. Exposing the log messages as a broadcast stream sounds good to me. |
ademar111190
force-pushed
the
aa/change-log-library
branch
from
612a2f8 to
7d8eb44
Compare
|
Good callout @roeierez I totally agree. |
ademar111190
changed the title
erdemyerebasmaz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK side of logging library changes breez/c-breez#657