Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use lightning-invoice crate exported by gl-client #791

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Feb 15, 2024

This PR replaces our explicit lightning-invoice dependency with the gl-client one, similar to how #779 did the same for the bitcoin crate.

The benefits we get are:

  • we reduce the dependency tree and binary size
    • no need to bundle both our lightning-invoice version and the one from gl-client
  • we help our SDK users easily choose the right lightning-invoice version
    • they can simply access it with breez_sdk_core::lightning_invoice

@ok300 ok300 requested review from JssDWt and roeierez February 15, 2024 12:54
@ok300
Copy link
Contributor Author

ok300 commented Feb 16, 2024

As discussed with Roei, I removed the re-exports, as we don't use those crates in our public APIs.

@ok300 ok300 force-pushed the ok300-consolidate-lightning-invoice-dependency branch from 66358bc to a9fccfa Compare February 16, 2024 11:34
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit 02994e2 into main Feb 18, 2024
7 checks passed
@ok300 ok300 deleted the ok300-consolidate-lightning-invoice-dependency branch March 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants