Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use lightning crate exported by gl-client #799

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Re-use lightning crate exported by gl-client #799

merged 2 commits into from
Feb 23, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Feb 19, 2024

This PR is the equivalent of #791 for the lightning dependency.

It includes:

  • bumping GL by one commit, such that it now re-exports its lightning dependency
  • removing the direct dependency from our Cargo.toml
  • updating our internal references to re-use the imported one from gl_client

@ok300 ok300 requested review from JssDWt and roeierez February 19, 2024 13:35
JssDWt
JssDWt approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It bumps GL by 3 commits)
ACK!

roeierez
roeierez approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit d554211 into main Feb 23, 2024
7 checks passed
@ok300 ok300 deleted the ok300-consolidate-lightning-dependency branch February 23, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JssDWt JssDWt JssDWt approved these changes

@roeierez roeierez roeierez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ok300 @roeierez @JssDWt